From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441AbcHVIjx (ORCPT ); Mon, 22 Aug 2016 04:39:53 -0400 Received: from mga04.intel.com ([192.55.52.120]:18077 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152AbcHVIjv (ORCPT ); Mon, 22 Aug 2016 04:39:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,559,1464678000"; d="scan'208";a="1045240162" From: Jani Nikula To: Heinrich Schuchardt , Patrik Jakobsson Cc: Joe Perches , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Heinrich Schuchardt Subject: Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll In-Reply-To: <1471809437-4377-1-git-send-email-xypron.glpk@gmx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1471809437-4377-1-git-send-email-xypron.glpk@gmx.de> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 22 Aug 2016 11:39:48 +0300 Message-ID: <87a8g5urhn.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Aug 2016, Heinrich Schuchardt wrote: > All components of variable clock should be initialized > to avoid bytes from the kernel stack to be exposed. > > Reported-by: Joe Perches > Signed-off-by: Heinrich Schuchardt > --- > drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c > index 28bd8f3..0277d85 100644 > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c > @@ -195,6 +195,7 @@ static bool mrst_lvds_find_best_pll(const struct gma_limit_t *limit, > struct gma_clock_t clock; > int err = target; > > + memset(clock, 0, sizeof(struct gma_clock_t)); Again, did you actually build this? This is hurting not helping us. It makes me think you didn't try your other patches either. BR, Jani. > memset(best_clock, 0, sizeof(*best_clock)); > > for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) { -- Jani Nikula, Intel Open Source Technology Center