From: Eric Anholt <eric@anholt.net>
To: Matthias Reichl <hias@horus.com>,
Vinod Koul <vinod.koul@intel.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>
Cc: Martin Sperl <kernel@martin.sperl.org>,
Clive Messer <clive.messer@digitaldreamtime.co.uk>,
dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: bcm2835: Fix cyclic DMA period splitting
Date: Mon, 13 Jun 2016 21:49:26 -0700 [thread overview]
Message-ID: <87a8iowf1l.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1465472504-10191-2-git-send-email-hias@horus.com>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
Matthias Reichl <hias@horus.com> writes:
> The code responsible for splitting periods into chunks that
> can be handled by the DMA controller missed to update total_len,
> the number of bytes processed in the current period, when there
> are more chunks to follow.
>
> Therefore total_len was stuck at 0 and the code didn't work at all.
> This resulted in a wrong control block layout and audio issues because
> the cyclic DMA callback wasn't executing on period boundaries.
>
> Fix this by adding the missing total_len update.
It looks like this issue has been around for a long time, and this fix
is pretty dependent on the recent refactors.
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-06-14 4:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 11:41 [PATCH 0/2] dmaengine: bcm2835: Cyclic DMA fixes Matthias Reichl
2016-06-09 11:41 ` [PATCH 1/2] dmaengine: bcm2835: Fix cyclic DMA period splitting Matthias Reichl
2016-06-14 4:49 ` Eric Anholt [this message]
2016-06-09 11:41 ` [PATCH 2/2] dmaengine: bcm2835: Avoid splitting periods into very small chunks Matthias Reichl
2016-06-14 5:06 ` Eric Anholt
2016-06-19 10:39 ` Matthias Reichl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8iowf1l.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=clive.messer@digitaldreamtime.co.uk \
--cc=dmaengine@vger.kernel.org \
--cc=hias@horus.com \
--cc=kernel@martin.sperl.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).