From: Philippe Troin <phil@fifi.org>
To: James Stevenson <james@stev.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.19: oops in ide-scsi
Date: 25 Sep 2002 09:46:13 -0700 [thread overview]
Message-ID: <87adm6kofe.fsf@ceramic.fifi.org> (raw)
In-Reply-To: <1032903706.2445.4.camel@god.stev.org>
James Stevenson <james@stev.org> writes:
> On Tue, 2002-09-24 at 22:00, Philippe Troin wrote:
> > James Stevenson <james@stev.org> writes:
> >
> > > Hi
> > >
> > > i am glad somebody else sees the same crash as me the
> > > request Q gets set to NULL for some reson then tries to
> > > increment a stats counter in the null pointer.
> > > i know what the bug is i just dont know how to fix it :>
> >
> > I'm not sure which Q you're talking about.
> > Is that rq (in idescsi_pc_intr())?
>
> the crash happens on
>
> if (status & ERR_STAT)
> rq->errors++;
>
> because
> struct request *rq = pc->rq;
> is NULL
Have you tried changing it to:
if (status & ERR_STAT && rq)
rq->errors++;
The code is going to return anyways, and rq is only used here on this
path.
BTW, can you reproduce the oops at will? I can't :-(
Phil.
next prev parent reply other threads:[~2002-09-25 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-24 1:08 2.4.19: oops in ide-scsi Philippe Troin
2002-09-24 18:26 ` James Stevenson
2002-09-24 21:00 ` Philippe Troin
2002-09-24 21:41 ` James Stevenson
2002-09-25 16:46 ` Philippe Troin [this message]
2002-09-25 18:18 ` James Stevenson
2002-09-25 22:30 ` Philippe Troin
2002-09-26 8:51 ` James Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87adm6kofe.fsf@ceramic.fifi.org \
--to=phil@fifi.org \
--cc=james@stev.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).