From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7BD9C4332F for ; Fri, 25 Nov 2022 12:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbiKYMZw (ORCPT ); Fri, 25 Nov 2022 07:25:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbiKYMZe (ORCPT ); Fri, 25 Nov 2022 07:25:34 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 869764A06C; Fri, 25 Nov 2022 04:25:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3F6EEB82A7F; Fri, 25 Nov 2022 12:25:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8A49C433C1; Fri, 25 Nov 2022 12:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669379130; bh=DqATjoDdGbI5qFOAhjGZDzH4dISayTbwqiw8HBaJ0vk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pAOrHdcfwA0pyNH03RhyC5HzlLAsSyewkGYEbAzaaXcZmjd30vl6NwqsX4XHhhO79 FfmlLZE58yHKCE4ahG5aD+NSivhdN/a6Ff5Mz5JP4HdWcbZqFvfz4l/GMdbYpxGZpA UW+3pZc+RYC7qhqC8V/ljuXyiZ3+A+qikXhEj9XppzGg1XZhbDGtVIzpQwckrAXWnK hnmNniXckscWOJ/yANG887BUxlIvLgLA7qgj6XX5nFvSF16P8Z13P/7u+ZQZqVBFw3 ac4PqLm6hjOPcnnEFiC6OmdoSBODm4J12KKkk4r2lrXmg+lCblkTv5px6WumHxIYH0 fOL0L+J5zxZRQ== From: Kalle Valo To: Konrad Dybcio Cc: Linus Walleij , Alvin =?utf-8?Q?=C5=A0iprag?= =?utf-8?Q?a?= , Hector Martin , "~postmarketos\/upstreaming\@lists.sr.ht" <~postmarketos/upstreaming@lists.sr.ht>, "martin.botka\@somainline.org" , "angelogioacchino.delregno\@somainline.org" , "marijn.suijten\@somainline.org" , "jamipkettunen\@somainline.org" , Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , "Zhao\, Jiaqing" , "Russell King \(Oracle\)" , Soon Tak Lee , "linux-wireless\@vger.kernel.org" , "brcm80211-dev-list.pdl\@broadcom.com" , "SHA-cyfmac-dev-list\@infineon.com" , "netdev\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi References: <20220921001630.56765-1-konrad.dybcio@somainline.org> <83b90478-3974-28e6-cf13-35fc4f62e0db@marcan.st> <13b8c67c-399c-d1a6-4929-61aea27aa57d@somainline.org> <0e65a8b2-0827-af1e-602c-76d9450e3d11@marcan.st> <7fd077c5-83f8-02e2-03c1-900a47f05dc1@somainline.org> <20220922133056.eo26da4npkg6bpf2@bang-olufsen.dk> <87sfke32pc.fsf@kernel.org> <4592f87a-bb61-1c28-13f0-d041a6e7d3bf@linaro.org> <87fse76yig.fsf@kernel.org> Date: Fri, 25 Nov 2022 14:25:21 +0200 In-Reply-To: (Konrad Dybcio's message of "Fri, 25 Nov 2022 13:10:53 +0100") Message-ID: <87bkov6x1q.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Konrad Dybcio writes: > On 25.11.2022 12:53, Kalle Valo wrote: >> Konrad Dybcio writes: >> >>> On 21.11.2022 14:56, Linus Walleij wrote: >>>> On Fri, Nov 18, 2022 at 5:47 PM Konrad Dybcio wrote: >>>> >>>>> I can think of a couple of hacky ways to force use of 43596 fw, but I >>>>> don't think any would be really upstreamable.. >>>> >>>> If it is only known to affect the Sony Xperias mentioned then >>>> a thing such as: >>>> >>>> if (of_machine_is_compatible("sony,xyz") || >>>> of_machine_is_compatible("sony,zzz")... ) { >>>> // Enforce FW version >>>> } >>>> >>>> would be completely acceptable in my book. It hammers the >>>> problem from the top instead of trying to figure out itsy witsy >>>> details about firmware revisions. >>>> >>>> Yours, >>>> Linus Walleij >>> >>> Actually, I think I came up with a better approach by pulling a page >>> out of Asahi folks' book - please take a look and tell me what you >>> think about this: >>> >>> [1] >>> https://github.com/SoMainline/linux/commit/4b6fccc995cd79109b0dae4e4ab2e48db97695e7 >>> [2] >>> https://github.com/SoMainline/linux/commit/e3ea1dc739634f734104f37fdbed046873921af7 >> >> Instead of a directory path ("brcm/brcmfmac43596-pcie") why not provide >> just the chipset name ("brcmfmac43596-pcie")? IMHO it's unnecessary to >> have directory names in Device Tree. > > I think it's common practice to include a full $FIRMWARE_DIR-relative > path when specifying firmware in DT, though here I left out the board > name bit as that's assigned dynamically anyway. That said, if you don't > like it, I can change it. It's just that I have understood that Device Tree is supposed to describe hardware and to me a firmware directory "brcm/" is a software property, not a hardware property. But this is really for the Device Tree maintainers to decide, they know this best :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches