From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87704C4332F for ; Wed, 23 Nov 2022 17:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239266AbiKWRKD (ORCPT ); Wed, 23 Nov 2022 12:10:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239052AbiKWRJh (ORCPT ); Wed, 23 Nov 2022 12:09:37 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4077E5BD69; Wed, 23 Nov 2022 09:09:36 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669223374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=emB+iXli2K14p1fLywmYz4u6q5gZrpX+yrCo0Lm/JxM=; b=vlcKj/roGj/uIjrnqmrI3gds3DmiRYaWqPQN+LmOQCzue232QraapV3E/elU5JwaQO2zuC y02JeTz2MbFDXmdYuOOOQK25Rpzi4Fo1O7f1JK4d3ZM0W9rYX2MzoaJUjaxTJad86j+XE2 1+j+zUHAOzp5TncHZZvbz7MoLuJeOn01ZFOkX9s4/ypJpIn+wlJtwbT8hCNyB0Sthj53I/ 3+iAqN5L2/KelMjAqbroSlKnlERDlxLuvFn7jSN7Mijg6CiuJXmM6bRkVw3bZOfV9Y1528 XJNP8VWo+aaiyzV5s5nKSzkhbGJELNER3BF9eL/pPznieTJ0rAgMHPg006qB3Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669223374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=emB+iXli2K14p1fLywmYz4u6q5gZrpX+yrCo0Lm/JxM=; b=4a2X0x1RX72mpHDImJjTL7xgB4XsHmhyUvOFgVuC0WHbNZtLrUn1h4QWEFVNcHUbiV7FBx l0Ri4PKJIDtsJqDw== To: Anna-Maria Behnsen Cc: LKML , Linus Torvalds , Steven Rostedt , Peter Zijlstra , Stephen Boyd , Guenter Roeck , Andrew Morton , Julia Lawall , Arnd Bergmann , Viresh Kumar , Marc Zyngier , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: Re: [patch V2 07/17] timers: Update kernel-doc for various functions In-Reply-To: References: <20221122171312.191765396@linutronix.de> <20221122173648.501792201@linutronix.de> Date: Wed, 23 Nov 2022 18:09:33 +0100 Message-ID: <87bkoxegxe.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23 2022 at 11:23, Anna-Maria Behnsen wrote: >> /** >> - * add_timer_on - start a timer on a particular CPU >> - * @timer: the timer to be added >> - * @cpu: the CPU to start it on >> + * add_timer_on - Start a timer on a particular CPU >> + * @timer: The timer to be started >> + * @cpu: The CPU to start it on >> * >> - * This is not very scalable on SMP. Double adds are not possible. >> + * This can only operate on an inactive timer. Attempts to invoke this on >> + * an active timer are rejected with a warning. > > This is also true for add_timer(). Is it possible to add this to > add_timer() function description and just referencing to add_timer() > function description in add_timer_on()? They behave the same, only > difference is the CPU where the timer is enqueued. Indeed.