From: Thomas Gleixner <tglx@linutronix.de>
To: Hao Peng <flyingpenghao@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/irq: Make irq_set_affinity_hint return the real return value
Date: Mon, 06 Sep 2021 11:50:05 +0200 [thread overview]
Message-ID: <87bl569goi.ffs@tglx> (raw)
In-Reply-To: <CAPm50aL9trE88p59KFj-UfEKMji5Ouyjtk=eq55JnSzGZ12WsQ@mail.gmail.com>
On Mon, Sep 06 2021 at 16:20, Hao Peng wrote:
> irq_set_affinity_hint does not return the return value of
> __irq_set_affinity, which makes the state of functions dependent
> on the return value of irq_set_affinity_hint inconsistent.
No, it does not. The affinity hint has been installed even in the case
that __irq_set_affinity() fails.
Setting the affinity in that function is a best effort operation without
any guarantees and in hindsight this should have never been added to
this function.
Thanks,
tglx
prev parent reply other threads:[~2021-09-06 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 8:20 [PATCH] kernel/irq: Make irq_set_affinity_hint return the real return value Hao Peng
2021-09-06 9:50 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl569goi.ffs@tglx \
--to=tglx@linutronix.de \
--cc=flyingpenghao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).