linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Henriques <lhenriques@suse.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm <linux-mm@kvack.org>
Subject: Re: fuse: kernel BUG at mm/truncate.c:763!
Date: Mon, 03 May 2021 09:52:05 +0100	[thread overview]
Message-ID: <87bl9std3d.fsf@suse.de> (raw)
In-Reply-To: <20210329120532.GB351017@casper.infradead.org> (Matthew Wilcox's message of "Mon, 29 Mar 2021 13:05:32 +0100")

Matthew Wilcox <willy@infradead.org> writes:

> On Mon, Mar 29, 2021 at 10:01:58AM +0100, Luis Henriques wrote:
>> On Fri, Mar 19, 2021 at 09:02:33AM +0000, Luis Henriques wrote:
>> > On Thu, Mar 18, 2021 at 11:55:43AM +0000, Matthew Wilcox wrote:
>> > > On Thu, Mar 18, 2021 at 11:29:28AM +0000, Luis Henriques wrote:
>> > > > On Thu, Mar 18, 2021 at 02:03:02PM +0300, Kirill A. Shutemov wrote:
>> > > > > On Thu, Mar 18, 2021 at 11:59:59AM +0100, Miklos Szeredi wrote:
>> > > > > > > [16247.536348] page:00000000dfe36ab1 refcount:673 mapcount:0 mapping:00000000f982a7f8 index:0x1400 pfn:0x4c65e00
>> > > > > > > [16247.536359] head:00000000dfe36ab1 order:9 compound_mapcount:0 compound_pincount:0
>> > > > > > 
>> > > > > > This is a compound page alright.   Have no idea how it got into fuse's
>> > > > > > pagecache.
>> > > > > 
>> > > > > 
>> > > > > Luis, do you have CONFIG_READ_ONLY_THP_FOR_FS enabled?
>> > > > 
>> > > > Yes, it looks like Tumbleweed kernels have that config option enabled by
>> > > > default.  And it this feature was introduced in 5.4 (the bug doesn't seem
>> > > > to be reproducible in 5.3).
>> > > 
>> > > Can you try adding this patch?
>> > > 
>> > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/369a4fcd78369b7a026bdef465af9669bde98ef4
>> > 
>> > Good news, looks like this patch fixes the issue[1].  Thanks a lot
>> > everyone.  Is this already queued somewhere for 5.12?  Also, it would be
>> > nice to have it Cc'ed for stable kernels >= 5.4.
>> 
>> Ping.  Are you planning to push this for 5.12, or is that queued for the
>> 5.13 merged window?  Or "none of the above"? :)
>
> Sorry, dropped the ball on this one.  This patch is good for that point
> in the patch series, but I'm not sure it works against upstream in all
> cases.  I need to spend some time evaluating it.  Thanks for the reminder.

Gentle ping :-)

Any chances of getting this into 5.13?  (And tagged for stable kernels.)

Cheers,
-- 
Luis

      reply	other threads:[~2021-05-03  8:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  8:52 fuse: kernel BUG at mm/truncate.c:763! Luis Henriques
2021-03-12  9:48 ` Miklos Szeredi
2021-03-12 12:21   ` Luis Henriques
2021-03-12 13:11     ` Matthew Wilcox
2021-03-15  9:47       ` Luis Henriques
2021-03-15 11:06         ` Matthew Wilcox
2021-03-18  9:26           ` Luis Henriques
2021-03-18 10:59             ` Miklos Szeredi
2021-03-18 11:03               ` Kirill A. Shutemov
2021-03-18 11:29                 ` Luis Henriques
2021-03-18 11:55                   ` Matthew Wilcox
2021-03-18 12:16                     ` Luis Henriques
2021-03-19  9:02                     ` Luis Henriques
2021-03-29  9:01                       ` Luis Henriques
2021-03-29 12:05                         ` Matthew Wilcox
2021-05-03  8:52                           ` Luis Henriques [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl9std3d.fsf@suse.de \
    --to=lhenriques@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).