From: NeilBrown <neilb@suse.de>
To: Fox Chen <foxhlchen@gmail.com>,
corbet@lwn.net, vegard.nossum@oracle.com,
viro@zeniv.linux.org.uk, rdunlap@infradead.org,
grandmaster@al2klimov.de
Cc: Fox Chen <foxhlchen@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/12] docs: path-lookup: update path_mountpoint() part
Date: Thu, 28 Jan 2021 14:28:51 +1100 [thread overview]
Message-ID: <87bld9hh8s.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20210126072443.33066-4-foxhlchen@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]
On Tue, Jan 26 2021, Fox Chen wrote:
> path_mountpoint() doesn't exist anymore. Have been folded
> into path_lookup_at when flag is set with LOOKUP_MOUNTPOINT.
> check out commit:161aff1d93abf0e5b5e9dbca88928998c155f677
>
> Signed-off-by: Fox Chen <foxhlchen@gmail.com>
> ---
> Documentation/filesystems/path-lookup.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/path-lookup.rst b/Documentation/filesystems/path-lookup.rst
> index 2ad96e1e3c49..4e77c8520fa9 100644
> --- a/Documentation/filesystems/path-lookup.rst
> +++ b/Documentation/filesystems/path-lookup.rst
> @@ -492,7 +492,8 @@ not try to revalidate the mounted filesystem. It effectively
> contains, through a call to ``mountpoint_last()``, an alternate
> implementation of ``lookup_slow()`` which skips that step. This is
> important when unmounting a filesystem that is inaccessible, such as
> -one provided by a dead NFS server.
> +one provided by a dead NFS server. In the current kernel, path_mountpoint
> +has been merged into ``path_lookup_at()`` with a new flag LOOKUP_MOUNTPOINT.
You've taken a very different approach here. Rather than re-telling the
story you have added a note (like a foot-note) that the details have
changed, withouy trying to re-weave the story. The is easier to get
right, but doesn't produce as nice a result.
Maybe this is a good approach, it depends on how much effort you are
willing/able to spend on the task.
IF you do stick with this approach: it is "path_lookupat", not
"path_lookup_at".
NeilBrown
>
> Finally ``path_openat()`` is used for the ``open()`` system call; it
> contains, in support functions starting with "``do_last()``", all the
> --
> 2.30.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2021-01-28 3:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 7:24 [PATCH 00/12] docs: path-lookup: Update pathlookup docs Fox Chen
2021-01-26 7:24 ` [PATCH 01/12] docs: path-lookup: update follow_managed() part Fox Chen
2021-01-26 14:03 ` Greg KH
2021-01-27 1:11 ` Fox Chen
2021-01-28 3:20 ` NeilBrown
2021-01-26 7:24 ` [PATCH 02/12] docs: path-lookup: update path_to_nameidata() parth Fox Chen
2021-01-28 3:24 ` NeilBrown
2021-01-26 7:24 ` [PATCH 03/12] docs: path-lookup: update path_mountpoint() part Fox Chen
2021-01-28 3:28 ` NeilBrown [this message]
2021-01-26 7:24 ` [PATCH 04/12] docs: path-lookup: update do_last() part Fox Chen
2021-01-28 3:50 ` NeilBrown
2021-01-26 7:24 ` [PATCH 05/12] docs: path-lookup: remove filename_mountpoint Fox Chen
2021-01-26 7:24 ` [PATCH 06/12] docs: path-lookup: Add macro name to symlink limit description Fox Chen
2021-01-26 7:24 ` [PATCH 07/12] docs: path-lookup: i_op->follow_link replaced with i_op->get_link Fox Chen
2021-01-28 3:53 ` NeilBrown
2021-01-26 7:24 ` [PATCH 08/12] docs: path-lookup: update i_op->put_link and cookie description Fox Chen
2021-01-28 3:50 ` NeilBrown
2021-01-26 7:24 ` [PATCH 09/12] docs: path-lookup: no get_link() Fox Chen
2021-01-26 7:24 ` [PATCH 10/12] docs: path-lookup: update WALK_GET, WALK_PUT desc Fox Chen
2021-01-26 7:24 ` [PATCH 11/12] docs: path-lookup: update get_link() ->follow_link description Fox Chen
2021-01-26 7:24 ` [PATCH 12/12] docs: path-lookup: update symlink description Fox Chen
2021-01-26 7:30 ` [PATCH 00/12] docs: path-lookup: Update pathlookup docs Fox Chen
2021-01-26 20:31 ` Jonathan Corbet
2021-01-28 1:23 ` Fox Chen
2021-01-28 3:58 ` NeilBrown
2021-01-29 1:29 ` Fox Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bld9hh8s.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=corbet@lwn.net \
--cc=foxhlchen@gmail.com \
--cc=grandmaster@al2klimov.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vegard.nossum@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).