From: ebiederm@xmission.com (Eric W. Biederman)
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Collingbourne <pcc@google.com>,
Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>
Subject: [PATCH] signal/parics: Remove parsic specific definition of __ARCH_UAPI_SA_FLAGS
Date: Mon, 30 Nov 2020 11:30:05 -0600 [thread overview]
Message-ID: <87blfen46a.fsf_-_@x220.int.ebiederm.org> (raw)
In-Reply-To: <87pn3unbtv.fsf@x220.int.ebiederm.org> (Eric W. Biederman's message of "Mon, 30 Nov 2020 08:44:44 -0600")
Randy Dunlap wrote:
> On 11/27/20 10:43 AM, Randy Dunlap wrote:
>
> > on parisc, _SA_SIGGFAULT is undefined and causing build errors.
> >
> > commit 23acdc76f1798b090bb9dcc90671cd29d929834e
> > Author: Peter Collingbourne <pcc@google.com>
> > Date: Thu Nov 12 18:53:34 2020 -0800
> >
> > signal: clear non-uapi flag bits when passing/returning sa_flags
> >
> >
> >
> > _SA_SIGGFAULT is not used or defined anywhere else in the
> > kernel source tree.
>
>
> Here is the build error (although it should be obvious):
>
> ../kernel/signal.c: In function 'do_sigaction':
> ../arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function)
> 24 | #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> | ^~~~~~~~~~~~~
Stephen Rothwell pointed out:
> _SA_SIGGFAULT was removed by commit
>
> 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
>
> which was added to Linus' tree in v5.10-rc1.
Solve this by removing the the parisc specific definition of
__ARCH_UAPI_SA_FLAGS that was just added.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
arch/parisc/include/asm/signal.h | 2 --
1 file changed, 2 deletions(-)
I am applying this trivial fix to my signal-for-v5.11 branch. Catalin
you shouldn't need to do anything unless someone tests your tree on
parisc.
diff --git a/arch/parisc/include/asm/signal.h b/arch/parisc/include/asm/signal.h
index 30dd1e43ef88..715c96ba2ec8 100644
--- a/arch/parisc/include/asm/signal.h
+++ b/arch/parisc/include/asm/signal.h
@@ -21,8 +21,6 @@ typedef struct {
unsigned long sig[_NSIG_WORDS];
} sigset_t;
-#define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
-
#include <asm/sigcontext.h>
#endif /* !__ASSEMBLY */
--
2.20.1
next prev parent reply other threads:[~2020-11-30 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 9:04 linux-next: Tree for Nov 27 Stephen Rothwell
2020-11-27 15:57 ` linux-next: Tree for Nov 27 (drivers/idle/intel_idle.c) Randy Dunlap
2020-11-27 21:36 ` Stephen Rothwell
2020-11-27 21:38 ` Randy Dunlap
2020-11-30 11:54 ` Peter Zijlstra
2020-11-30 16:44 ` Randy Dunlap
2020-12-03 9:07 ` [tip: locking/urgent] intel_idle: Build fix tip-bot2 for Peter Zijlstra
2020-11-27 18:43 ` linux-next: Tree for Nov 27 (parisc: signal flags) Randy Dunlap
2020-11-27 19:12 ` Randy Dunlap
2020-11-27 21:44 ` Stephen Rothwell
2020-11-30 14:44 ` Eric W. Biederman
2020-11-30 17:30 ` Eric W. Biederman [this message]
2020-11-30 19:15 ` [PATCH] signal/parics: Remove parsic specific definition of __ARCH_UAPI_SA_FLAGS Randy Dunlap
2020-11-30 19:46 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blfen46a.fsf_-_@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=catalin.marinas@arm.com \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=pcc@google.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).