From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30FCDC433E2 for ; Tue, 14 Jul 2020 09:42:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0840921D7A for ; Tue, 14 Jul 2020 09:42:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="cE91BZeY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726748AbgGNJmJ (ORCPT ); Tue, 14 Jul 2020 05:42:09 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:11180 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbgGNJmJ (ORCPT ); Tue, 14 Jul 2020 05:42:09 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594719729; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=rwaiPjJK4tdDLIrGur1Wip379yC4QzqC1DFY1MsdhpI=; b=cE91BZeYSoAVFTZX9/Olol/CSa281xtxuDAgmckk81+GrA21bNsImCb1V8OzvyXofBnpgDs3 6B1HX2y594Vqf1so3LBmj6kw+TW1MQq9z3RACbEnEnyuqEBqa2jqMFZlaZgvRG4XvzZoEqQZ X9O8ZNqS0wK1ZeKWWwZjwTwLuCo= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-west-2.postgun.com with SMTP id 5f0d7de7ee6926bb4f054441 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 14 Jul 2020 09:41:59 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DC794C433A1; Tue, 14 Jul 2020 09:41:58 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6DEE0C433CB; Tue, 14 Jul 2020 09:41:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6DEE0C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Nicolas Saenz Julienne Cc: linux-kernel@vger.kernel.org, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org Subject: Re: [PATCH] brcmfmac: set timeout value when configuring power save References: <20200707155410.12123-1-nsaenzjulienne@suse.de> Date: Tue, 14 Jul 2020 12:41:52 +0300 In-Reply-To: <20200707155410.12123-1-nsaenzjulienne@suse.de> (Nicolas Saenz Julienne's message of "Tue, 7 Jul 2020 17:54:10 +0200") Message-ID: <87blkicu1r.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nicolas Saenz Julienne writes: > Set the timeout value as per cfg80211's set_power_mgmt() request. If the > requested value value is left undefined we set it to 2 seconds, the > maximum supported value. > > Signed-off-by: Nicolas Saenz Julienne > --- > > Note: I got the 2 seconds value from the Raspberry Pi downstream kernel. > > .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > index a757abd7a599..15578c6e87cd 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c > @@ -84,6 +84,8 @@ > > #define BRCMF_ND_INFO_TIMEOUT msecs_to_jiffies(2000) > > +#define BRCMF_PS_MAX_TIMEOUT_MS 2000 > + > #define BRCMF_ASSOC_PARAMS_FIXED_SIZE \ > (sizeof(struct brcmf_assoc_params_le) - sizeof(u16)) > > @@ -2941,6 +2943,14 @@ brcmf_cfg80211_set_power_mgmt(struct wiphy *wiphy, struct net_device *ndev, > else > bphy_err(drvr, "error (%d)\n", err); > } > + > + if ((u32)timeout > BRCMF_PS_MAX_TIMEOUT_MS) > + timeout = BRCMF_PS_MAX_TIMEOUT_MS; Wouldn't min_t() be better? Then you won't need the ugly cast either. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches