From: Kalle Valo <kvalo@codeaurora.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Arvind Sankar" <nivedita@alum.mit.edu>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Nick Desaulniers" <ndesaulniers@google.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
"Kees Cook" <keescook@chromium.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Michael Matz" <matz@suse.de>, "Martin Liška" <mliska@suse.cz>,
"Jakub Jelinek" <jakub@redhat.com>
Subject: Re: [PATCH] x86: Fix early boot crash on gcc-10, third try
Date: Thu, 14 May 2020 17:45:50 +0300 [thread overview]
Message-ID: <87blmqr2w1.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200514132706.GB9266@zn.tnic> (Borislav Petkov's message of "Thu, 14 May 2020 15:27:06 +0200")
Borislav Petkov <bp@alien8.de> writes:
> Ok,
>
> here's the new version. Changes are:
>
> - It does mb() now (Linus).
> - I've added a call to prevent_tail_call_optimization() in init/main.c
> because it does generate the stack canary there too. This is a
> future-proof thing. (Arvind).
> - Dropped Reviewed-by tags.
> - Dropped compiler checking from the branch (Linus).
> - Added Cc:stable because gcc10 has released already, apparently.
>
> Testing with gcc10 passes after making sure that without it it would
> cause the tailcall optimization and fail stack check.
>
> Plan is to send it to Linus on the weekend so that it makes it into 5.7.
This fixed my boot issue, thanks!
Tested-by: Kalle Valo <kvalo@codeaurora.org>
[ 0.000000] Linux version 5.7.0-rc4-wt-ath+ (gcc version 10.1.0 (GCC), GNU ld (GNU Binutils) 2.34) #11 SMP Thu May 14 17:28:35 EEST 2020
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-05-14 14:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 12:06 [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings Arnd Bergmann
2020-05-09 12:06 ` [PATCH net-next 2/2] ath10k: fix ath10k_pci struct layout Arnd Bergmann
2020-05-11 12:05 ` Kalle Valo
2020-05-11 12:17 ` Kalle Valo
2020-05-11 12:39 ` Arnd Bergmann
2020-05-13 6:50 ` gcc-10: kernel stack is corrupted and fails to boot Kalle Valo
2020-05-13 8:49 ` Arnd Bergmann
2020-05-13 12:45 ` Kalle Valo
2020-05-13 13:45 ` Arnd Bergmann
2020-05-13 15:31 ` Kalle Valo
2020-05-13 16:00 ` Arnd Bergmann
2020-05-13 16:07 ` David Laight
2020-05-14 9:13 ` Harald Arnesen
2020-05-13 15:48 ` Arvind Sankar
2020-05-13 21:28 ` Arnd Bergmann
2020-05-13 21:41 ` Borislav Petkov
2020-05-13 21:49 ` Arnd Bergmann
2020-05-13 22:20 ` Borislav Petkov
2020-05-13 22:51 ` Arvind Sankar
2020-05-13 23:13 ` Linus Torvalds
2020-05-13 23:36 ` Borislav Petkov
2020-05-14 0:11 ` Linus Torvalds
2020-05-14 0:51 ` Nick Desaulniers
2020-05-14 2:20 ` Linus Torvalds
2020-05-14 3:50 ` Andy Lutomirski
[not found] ` <CAHk-=wgiGxRgJGS-zyer1C_x2MQUVo6iZn0=aJyuFTqJWk-mpA@mail.gmail.com>
2020-05-14 5:22 ` Arvind Sankar
2020-05-14 8:40 ` Arnd Bergmann
2020-05-14 13:27 ` [PATCH] x86: Fix early boot crash on gcc-10, third try Borislav Petkov
2020-05-14 14:45 ` Kalle Valo [this message]
2020-05-14 15:50 ` gcc-10: kernel stack is corrupted and fails to boot Arvind Sankar
2020-05-14 8:11 ` David Laight
2020-05-13 23:07 ` Linus Torvalds
2020-05-09 15:48 ` [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings Gustavo A. R. Silva
2020-05-11 12:02 ` Kalle Valo
2020-05-11 12:46 ` Arnd Bergmann
2020-05-11 13:09 ` Kalle Valo
2020-05-11 13:47 ` Arnd Bergmann
2020-05-12 7:33 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blmqr2w1.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=jakub@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=matz@suse.de \
--cc=mliska@suse.cz \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).