linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Jia-Ju Bai <baijiaju1990@gmail.com>,
	gregkh@linuxfoundation.org, nicolas.ferre@microchip.com,
	keescook@chromium.org, allen.lkml@gmail.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller()
Date: Fri, 29 Jun 2018 14:15:19 +0300	[thread overview]
Message-ID: <87bmbtetdk.fsf@linux.intel.com> (raw)
In-Reply-To: <87a7rdlup1.fsf@belgarion.home>


Hi,

Robert Jarzmik <robert.jarzmik@free.fr> writes:
>>> And as bonus question, why is it better to have mdelay() calls in the driver ?
>>
>> As a bugfix, it's the smallest fix possible, right? Ideally, we wouldn't
>> need either of them. Perhaps there's a bit which can be polled instead?
> Ideally yes. Do you remember if a "threaded interrupt" might use msleep() ? I
> seem to remember that they can, so won't that be another alternative ?

yeah, unless, of course, you have a spinlock held. ;-)

-- 
balbi

  reply	other threads:[~2018-06-29 11:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  3:54 [PATCH 1/2] usb: gadget: r8a66597: Fix two possible sleep-in-atomic-context bugs in init_controller() Jia-Ju Bai
2018-06-21  9:06 ` Robert Jarzmik
2018-06-29  6:35   ` Felipe Balbi
2018-06-29  6:48     ` Robert Jarzmik
2018-06-29 10:25       ` Felipe Balbi
2018-06-29 11:04         ` Robert Jarzmik
2018-06-29 11:15           ` Felipe Balbi [this message]
2018-06-29 13:21             ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmbtetdk.fsf@linux.intel.com \
    --to=balbi@kernel.org \
    --cc=allen.lkml@gmail.com \
    --cc=baijiaju1990@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).