* [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag
@ 2018-01-10 16:28 Arnd Bergmann
2018-01-10 20:22 ` Robert Jarzmik
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2018-01-10 16:28 UTC (permalink / raw)
To: Daniel Mack, Haojian Zhuang, Robert Jarzmik
Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel
Without this tag, we get a build warning:
WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o
For completeness, I'm also adding author and description fields.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-pxa/tosa-bt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-pxa/tosa-bt.c b/arch/arm/mach-pxa/tosa-bt.c
index 107f37210fb9..83606087edc7 100644
--- a/arch/arm/mach-pxa/tosa-bt.c
+++ b/arch/arm/mach-pxa/tosa-bt.c
@@ -132,3 +132,7 @@ static struct platform_driver tosa_bt_driver = {
},
};
module_platform_driver(tosa_bt_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Dmitry Baryshkov");
+MODULE_DESCRIPTION("Bluetooth built-in chip control");
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag
2018-01-10 16:28 [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag Arnd Bergmann
@ 2018-01-10 20:22 ` Robert Jarzmik
2018-01-19 16:02 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Robert Jarzmik @ 2018-01-10 20:22 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Daniel Mack, Haojian Zhuang, linux-arm-kernel, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> Without this tag, we get a build warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o
>
> For completeness, I'm also adding author and description fields.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Queued into pxa/for-next, thanks.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag
2018-01-10 20:22 ` Robert Jarzmik
@ 2018-01-19 16:02 ` Arnd Bergmann
2018-01-19 17:18 ` Robert Jarzmik
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2018-01-19 16:02 UTC (permalink / raw)
To: Robert Jarzmik
Cc: Daniel Mack, Haojian Zhuang, Linux ARM,
Linux Kernel Mailing List, arm-soc
On Wed, Jan 10, 2018 at 9:22 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
>> Without this tag, we get a build warning:
>>
>> WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o
>>
>> For completeness, I'm also adding author and description fields.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Queued into pxa/for-next, thanks.
I see now that you didn't send this back to arm@kernel.org. I assume you planned
to send it for 4.17, but kernelci now still reports the warning for
both 4.15 and
linux-next (4.16). Should we just include this patch in the 4.16 fixes instead?
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag
2018-01-19 16:02 ` Arnd Bergmann
@ 2018-01-19 17:18 ` Robert Jarzmik
2018-01-22 11:36 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Robert Jarzmik @ 2018-01-19 17:18 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Daniel Mack, Haojian Zhuang, Linux ARM,
Linux Kernel Mailing List, arm-soc
Arnd Bergmann <arnd@arndb.de> writes:
> On Wed, Jan 10, 2018 at 9:22 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> Arnd Bergmann <arnd@arndb.de> writes:
>>
>>> Without this tag, we get a build warning:
>>>
>>> WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o
>>>
>>> For completeness, I'm also adding author and description fields.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Queued into pxa/for-next, thanks.
>
> I see now that you didn't send this back to arm@kernel.org. I assume you planned
> to send it for 4.17, but kernelci now still reports the warning for
> both 4.15 and
> linux-next (4.16). Should we just include this patch in the 4.16 fixes
> instead?
Yeah sure, go ahead and merge it into 4.16 staging branch, with my :
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag
2018-01-19 17:18 ` Robert Jarzmik
@ 2018-01-22 11:36 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2018-01-22 11:36 UTC (permalink / raw)
To: Robert Jarzmik
Cc: Daniel Mack, Haojian Zhuang, Linux ARM,
Linux Kernel Mailing List, arm-soc
On Fri, Jan 19, 2018 at 6:18 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
>> On Wed, Jan 10, 2018 at 9:22 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>>> Arnd Bergmann <arnd@arndb.de> writes:
>>>
>>>> Without this tag, we get a build warning:
>>>>
>>>> WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o
>>>>
>>>> For completeness, I'm also adding author and description fields.
>>>>
>>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Queued into pxa/for-next, thanks.
>>
>> I see now that you didn't send this back to arm@kernel.org. I assume you planned
>> to send it for 4.17, but kernelci now still reports the warning for
>> both 4.15 and
>> linux-next (4.16). Should we just include this patch in the 4.16 fixes
>> instead?
> Yeah sure, go ahead and merge it into 4.16 staging branch, with my :
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Applied to next/soc now, thanks!
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-22 11:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 16:28 [PATCH] ARM: pxa/tosa-bt: add MODULE_LICENSE tag Arnd Bergmann
2018-01-10 20:22 ` Robert Jarzmik
2018-01-19 16:02 ` Arnd Bergmann
2018-01-19 17:18 ` Robert Jarzmik
2018-01-22 11:36 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).