From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755025AbdK1Lhk (ORCPT ); Tue, 28 Nov 2017 06:37:40 -0500 Received: from ozlabs.org ([103.22.144.67]:35439 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752832AbdK1Lhi (ORCPT ); Tue, 28 Nov 2017 06:37:38 -0500 From: Michael Ellerman To: Shilpasri G Bhat , linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com, akshay.adiga@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com, Shilpasri G Bhat Subject: Re: [PATCH] powerpc/powernv : Add support to enable sensor groups In-Reply-To: <1511760988-10377-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> References: <1511760988-10377-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> Date: Tue, 28 Nov 2017 22:37:36 +1100 Message-ID: <87bmjmzla7.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shilpasri G Bhat writes: > Adds support to enable/disable a sensor group. This can be used to > select the sensor groups that needs to be copied to main memory by > OCC. Sensor groups like power, temperature, current, voltage, > frequency, utilization can be enabled/disabled at runtime. > > Signed-off-by: Shilpasri G Bhat > --- > The skiboot patch for the opal call is posted below: > https://lists.ozlabs.org/pipermail/skiboot/2017-November/009713.html Can you remind me why we're doing this with a completely bespoke sysfs API, rather than using some generic sensors API? And if we must do it that way, please add documentation for the sysfs file(s) in Documentation/ABI/. cheers