From: Michael Mera <dev@michaelmera.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-kernel@vger.kernel.org, Michael Mera <dev@michaelmera.com>
Subject: Re: [PATCH v2] staging: speakup: fix wrong code indent
Date: Fri, 28 Apr 2017 18:11:04 +0900 [thread overview]
Message-ID: <87bmrgj3rr.fsf@michaelmera.com> (raw)
In-Reply-To: <20170428090034.GA3436@kroah.com>
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote:
>> Remove unnecessary multiline comment, fixes checkpatch messages:
>> ERROR: code indent should use tabs where possible
>> WARNING: Block comments should align the * on each line
>>
>> Signed-off-by: Michael Mera <dev@michaelmera.com>
>> ---
>> drivers/staging/speakup/speakup_decpc.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> What changed from v1? That needs to go below the --- line.
Oh. Sorry. I fixed the spelling of the patch message, since I
though that was the problem you detected but...
>
> And I think my previous email still is relevant here...
... apparently not. I double checked the patch with 'checkpatch --strict'
and it does not detect any problem this time.
Sorry if I missed something obvious, I am quite new to this, but could
you give me some additional hint about the problem.
next prev parent reply other threads:[~2017-04-28 9:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 6:20 [PATCH] staging: speakup: fix wrong code indent Michael Mera
2017-04-28 7:11 ` Greg Kroah-Hartman
2017-04-28 8:46 ` [PATCH v2] " Michael Mera
2017-04-28 9:00 ` Greg Kroah-Hartman
2017-04-28 9:11 ` Michael Mera [this message]
2017-04-28 9:36 ` Greg Kroah-Hartman
2017-04-28 14:43 ` [PATCH v3] " Michael Mera
2017-04-28 15:52 ` Greg Kroah-Hartman
2017-04-29 1:24 ` Michael Mera
2017-05-09 23:48 ` [PATCH v4] staging: speakup: fix unnecessary long line Michael Mera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmrgj3rr.fsf@michaelmera.com \
--to=dev@michaelmera.com \
--cc=chris@the-brannons.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).