From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbdCEOTa (ORCPT ); Sun, 5 Mar 2017 09:19:30 -0500 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:33583 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752317AbdCEOT2 (ORCPT ); Sun, 5 Mar 2017 09:19:28 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 05 Mar 2017 14:47:07 +0100 X-ME-IP: 92.149.63.23 From: Robert Jarzmik To: Philippe Reynes Cc: nico@fluxnic.net, davem@davemloft.net, mugunthanvnm@ti.com, jarod@redhat.com, felipe.balbi@linux.intel.com, rmk+kernel@armlinux.org.uk, fw@strlen.de, jeremy.linton@arm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings References: <1488627759-8717-1-git-send-email-tremyfr@gmail.com> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 05 Mar 2017 14:47:00 +0100 In-Reply-To: <1488627759-8717-1-git-send-email-tremyfr@gmail.com> (Philippe Reynes's message of "Sat, 4 Mar 2017 12:42:39 +0100") Message-ID: <87bmtfx2cr.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Philippe Reynes writes: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes > --- > Changelog: > v2: > - also update comment (feeback from Russel King) Ok, I tested it, with : ethtool -s eth0 duplex half autoneg off speed 10 ethtool eth0 => see the changes ping -f x.x.x.x ethtool -s eth0 duplex full autoneg on ethtool eth0 => see the changes ping -f x.x.x.x This both with your patch and without, it works in both cases, and the former as a smaller throughput, which makes me believe the patch is fine. Tested-by: Robert Jarzmik Cheers. -- Robert