From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932947AbdA0PYC (ORCPT ); Fri, 27 Jan 2017 10:24:02 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:38196 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932871AbdA0PXn (ORCPT ); Fri, 27 Jan 2017 10:23:43 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 85EFA607F2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Pali =?utf-8?Q?Roh=C3=A1r?= Cc: Arend Van Spriel , Ming Lei , "Luis R. Rodriguez" , Greg Kroah-Hartman , David Gnedt , Michal Kazior , Daniel Wagner , Tony Lindgren , Sebastian Reichel , Pavel Machek , Ivaylo Dimitrov , Aaro Koskinen , Grazvydas Ignotas , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data References: <1482598381-16513-3-git-send-email-pali.rohar@gmail.com> <87tw8lnei3.fsf@codeaurora.org> <20170127094342.GC24223@pali> <20170127101043.GD24223@pali> <20170127103408.GG24223@pali> <87bmus7mfk.fsf@kamboji.qca.qualcomm.com> <20170127115706.GH24223@pali> <8737g47kpd.fsf@kamboji.qca.qualcomm.com> <20170127131146.GI24223@pali> Date: Fri, 27 Jan 2017 17:23:07 +0200 In-Reply-To: <20170127131146.GI24223@pali> ("Pali \=\?utf-8\?Q\?Roh\=C3\=A1r\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 27 Jan 2017 14:11:46 +0100") Message-ID: <87bmus5xyc.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0RFO7xF002351 Pali Rohár writes: > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: >> Pali Rohár writes: >> >> > 2) It was already tested that example NVS data can be used for N900 e.g. >> > for SSH connection. If real correct data are not available it is better >> > to use at least those example (and probably log warning message) so user >> > can connect via SSH and start investigating where is problem. >> >> I disagree. Allowing default calibration data to be used can be >> unnoticed by user and left her wondering why wifi works so badly. > > So there are only two options: > > 1) Disallow it and so these users will have non-working wifi. > > 2) Allow those data to be used as fallback mechanism. > > And personally I'm against 1) because it will break wifi support for > *all* Nokia N900 devices right now. All two of them? :) But not working is exactly my point, if correct calibration data is not available wifi should not work. And it's not only about functionality problems, there's also the regulatory aspect. >> > 3) If we do rename *now* we will totally break wifi support on Nokia >> > N900. >> >> Then the distro should fix that when updating the linux-firmware >> packages. Can you provide details about the setup, what distro etc? > > Debian stable, Ubuntu LTSs 14.04, 16.04. You can run these out of box on N900? > And I think that other LTS distributions contains that example nvs > file too (I'm not going to verify others, but list will be probably > long). Upgrading linux-firmware is against policy of those > distributions. So no this is not an solution. So instead we should workaround distro policies in kernel? Come on. Seriously, just rename the file in linux-firmware and file a bug (with a patch) to distros. If they don't fix the bug you just have to do a custom hack for N900. But such is life. -- Kalle Valo