From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751212AbdAPKau (ORCPT ); Mon, 16 Jan 2017 05:30:50 -0500 Received: from mga14.intel.com ([192.55.52.115]:23665 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751226AbdAPKat (ORCPT ); Mon, 16 Jan 2017 05:30:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,238,1477983600"; d="asc'?scan'208";a="1094670747" From: Felipe Balbi To: Baolin Wang , mathias.nyman@intel.com Cc: gregkh@linuxfoundation.org, broonie@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH v5 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume In-Reply-To: <65c23bd7ea99c3ebfffd2ded65e32a0446814c38.1481532028.git.baolin.wang@linaro.org> References: <65c23bd7ea99c3ebfffd2ded65e32a0446814c38.1481532028.git.baolin.wang@linaro.org> Date: Mon, 16 Jan 2017 12:28:30 +0200 Message-ID: <87bmv7nvsh.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Baolin Wang writes: > For some mobile devices with strict power management, we also want to sus= pend > the host when the slave is detached for power saving. Thus we add the host > suspend/resume functions to support this requirement. > > Signed-off-by: Baolin Wang > --- > Changes since v4: > - Remove Kconfig and just enable host suspend/resume. > - Simplify the dwc3_host_suspend/resume() function. > > Changes since v3: > - No updates. > > Changes since v2: > - Remove pm_children_suspended() and other unused macros. > > Changes since v1: > - Add pm_runtime.h head file to avoid kbuild error. > --- > drivers/usb/dwc3/core.c | 26 +++++++++++++++++++++++++- > drivers/usb/dwc3/core.h | 7 +++++++ > drivers/usb/dwc3/host.c | 21 +++++++++++++++++++++ > 3 files changed, 53 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 9a4a5e4..7ad4bc3 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -1091,6 +1091,7 @@ static int dwc3_probe(struct platform_device *pdev) > pm_runtime_use_autosuspend(dev); > pm_runtime_set_autosuspend_delay(dev, DWC3_DEFAULT_AUTOSUSPEND_DELAY); > pm_runtime_enable(dev); > + pm_suspend_ignore_children(dev, true); > ret =3D pm_runtime_get_sync(dev); > if (ret < 0) > goto err1; > @@ -1215,15 +1216,27 @@ static int dwc3_remove(struct platform_device *pd= ev) > static int dwc3_suspend_common(struct dwc3 *dwc) > { > unsigned long flags; > + int ret; >=20=20 > switch (dwc->dr_mode) { > case USB_DR_MODE_PERIPHERAL: > + spin_lock_irqsave(&dwc->lock, flags); > + dwc3_gadget_suspend(dwc); > + spin_unlock_irqrestore(&dwc->lock, flags); > + break; > case USB_DR_MODE_OTG: > + ret =3D dwc3_host_suspend(dwc); > + if (ret) > + return ret; > + > spin_lock_irqsave(&dwc->lock, flags); > dwc3_gadget_suspend(dwc); > spin_unlock_irqrestore(&dwc->lock, flags); > break; > case USB_DR_MODE_HOST: > + ret =3D dwc3_host_suspend(dwc); > + if (ret) > + return ret; > default: > /* do nothing */ > break; > @@ -1245,12 +1258,23 @@ static int dwc3_resume_common(struct dwc3 *dwc) >=20=20 > switch (dwc->dr_mode) { > case USB_DR_MODE_PERIPHERAL: > + spin_lock_irqsave(&dwc->lock, flags); > + dwc3_gadget_resume(dwc); > + spin_unlock_irqrestore(&dwc->lock, flags); > + break; > case USB_DR_MODE_OTG: > + ret =3D dwc3_host_resume(dwc); > + if (ret) > + return ret; > + > spin_lock_irqsave(&dwc->lock, flags); > dwc3_gadget_resume(dwc); > spin_unlock_irqrestore(&dwc->lock, flags); > - /* FALLTHROUGH */ > + break; > case USB_DR_MODE_HOST: > + ret =3D dwc3_host_resume(dwc); > + if (ret) > + return ret; > default: > /* do nothing */ > break; > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index b585a30..1099168 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -1158,11 +1158,18 @@ static inline bool dwc3_is_usb31(struct dwc3 *dwc) > #if IS_ENABLED(CONFIG_USB_DWC3_HOST) || IS_ENABLED(CONFIG_USB_DWC3_DUAL_= ROLE) > int dwc3_host_init(struct dwc3 *dwc); > void dwc3_host_exit(struct dwc3 *dwc); > +int dwc3_host_suspend(struct dwc3 *dwc); > +int dwc3_host_resume(struct dwc3 *dwc); > #else > static inline int dwc3_host_init(struct dwc3 *dwc) > { return 0; } > static inline void dwc3_host_exit(struct dwc3 *dwc) > { } > + > +static inline int dwc3_host_suspend(struct dwc3 *dwc) > +{ return 0; } > +static inline int dwc3_host_resume(struct dwc3 *dwc) > +{ return 0; } > #endif >=20=20 > #if IS_ENABLED(CONFIG_USB_DWC3_GADGET) || IS_ENABLED(CONFIG_USB_DWC3_DUA= L_ROLE) > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c > index ed82464..7959ef0 100644 > --- a/drivers/usb/dwc3/host.c > +++ b/drivers/usb/dwc3/host.c > @@ -16,6 +16,7 @@ > */ >=20=20 > #include > +#include >=20=20 > #include "core.h" >=20=20 > @@ -130,3 +131,23 @@ void dwc3_host_exit(struct dwc3 *dwc) > dev_name(&dwc->xhci->dev)); > platform_device_unregister(dwc->xhci); > } > + > +int dwc3_host_suspend(struct dwc3 *dwc) > +{ > + struct device *xhci =3D &dwc->xhci->dev; > + > + /* > + * Note: if we get the -EBUSY, which means the xHCI children devices are > + * not in suspend state yet, the glue layer need to wait for a while and > + * try to suspend xHCI device again. > + */ > + return pm_runtime_put_sync(xhci); > +} > + > +int dwc3_host_resume(struct dwc3 *dwc) > +{ > + struct device *xhci =3D &dwc->xhci->dev; > + > + /* Resume the xHCI device synchronously. */ > + return pm_runtime_get_sync(xhci); > +} > --=20 > 1.7.9.5 I can't take this without Mathias taking xhci side of things. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlh8oE4ACgkQzL64meEa mQazsRAA2vkcN3dU/GPYQjpnT9C4/DkGHyzM1O1PS7uXXst5bbsF0rXP0DyQxlcX +Q0KldhdzmZwzgNF83P4/g83aWs+3cVErKSmhQYjBDONqtG7D15Ji53u4tVwEpJ7 QD7jpiJqw+Zrcv99yIzBl7cfeZkfpTzq5EoZABPBLiGCkf2iHnjHvc1h4pspO0N7 o47qcsshSoFIITyRkGJKCA8IiaWKNsDCygnKehQicuKNsd8/QyEuFONOI+hvKj6i NmJA39o5kMtcamq8F8da8VzOnmeiK9Aw4lXlTLm8vtGyfeA547Oplus3QBbTvkxi ROq1VARoGx/UOUh29OeARYYp9IEq7kcMhiL2/8ZR8I9eDVjrKxTTjqoadIDuzpAv LX3tdhNXj0E9k7fHGqwKYyFC2o0KILYmAr9zV/Wtf3Aokrq+0X38IiwvLa7BHGcU JqkkLJSSfXfhIV0SJHgw8KQhdDT1/I74b4vy79CTqr0vdc4KQ3PIS2CaPhvaWKIm n44Uc9e6wXEcjf1sXreH79KJlVyAJs2mA1lqq8r93WgxtaGp0ywqKE3Ya0SUEffF J+hS+4oHAefLzqHgr0vgPC+i0LuDkhoj8Fyn8bSDxqKkvEjwgCXSObiM4pu673rJ 7rCSpMTx5KuBMldlfk4Qf+hAwyk24d4k6xcTWTcUSgh2qpLzPyU= =Mmkg -----END PGP SIGNATURE----- --=-=-=--