linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	Jason Cooper <jason@lakedaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	"open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
Date: Wed, 04 Jan 2017 12:48:20 -0500	[thread overview]
Message-ID: <87bmvmvhqz.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170104174248.GG5517@lunn.ch>

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> That makes me think that we should either remove, or use different
>> values for the version described in net/dsa/dsa.c:
>> 
>>     char dsa_driver_version[] = "0.1";
>> 
>> Today this is absolutely useless and erroneous.
>
> I think it has been useless for over 9 years.

Do we want to get rid of it, or do we want to have a string version per
DSA implementation? (old vs. new bindings).

I don't like the actual way to distinguish between the two (grep'ing
dmesg as Florian shown). Maybe a pr_info in dsa2.c would be enough to
inform about DSA "v2". What do you guys prefer?

Thanks,

        Vivien

  reply	other threads:[~2017-01-04 17:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02  2:22 [PATCH 0/8] ARM: dts: Switch to new DSA binding Florian Fainelli
2017-01-02  2:22 ` [PATCH 1/8] ARM: dts: armada-370-rd: Utilize " Florian Fainelli
2017-01-03 16:36   ` Andrew Lunn
2017-01-04 17:30     ` Florian Fainelli
2017-01-05  9:41       ` Gregory CLEMENT
2017-01-02  2:22 ` [PATCH 2/8] ARM: dts: armada-38x: " Florian Fainelli
2017-01-03 16:14   ` Gregory CLEMENT
2017-01-02  2:22 ` [PATCH 3/8] ARM: dts: armada-388-clearfog: " Florian Fainelli
2017-01-02  8:59   ` Neil Armstrong
2017-01-04 17:23   ` Gregory CLEMENT
2017-01-04 17:27     ` Florian Fainelli
2017-01-04 17:38       ` Vivien Didelot
2017-01-04 17:42         ` Andrew Lunn
2017-01-04 17:48           ` Vivien Didelot [this message]
2017-01-05 12:55       ` Gregory CLEMENT
2017-01-02  2:22 ` [PATCH 4/8] ARM: dts: armada-xp-linksys-mamba: " Florian Fainelli
2017-01-02  2:22 ` [PATCH 5/8] ARM: dts: kirkwood-dir665: " Florian Fainelli
2017-01-02  2:22 ` [PATCH 6/8] ARM: dts: kirkwood-linksys-viper: " Florian Fainelli
2017-01-02  2:22 ` [PATCH 7/8] ARM: dts: kirkwood-mv88f6281gtw-ge: " Florian Fainelli
2017-01-02  2:22 ` [PATCH 8/8] ARM: dts: kirkwood-rd88f6281: " Florian Fainelli
2017-01-03 16:19 ` [PATCH 0/8] ARM: dts: Switch to " Gregory CLEMENT
2017-01-03 16:32   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmvmvhqz.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).