From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751181AbcGQPUY (ORCPT ); Sun, 17 Jul 2016 11:20:24 -0400 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:60102 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751072AbcGQPUV (ORCPT ); Sun, 17 Jul 2016 11:20:21 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 17 Jul 2016 17:20:19 +0200 X-ME-IP: 92.149.188.117 From: Robert Jarzmik To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Dan Carpenter Cc: "Rafael J. Wysocki" , Viresh Kumar , "Luis R. Rodriguez" , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] video: fbdev: pxafb: potential NULL dereference on error References: <20160715110732.GC9258@mwanda> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 17 Jul 2016 17:20:12 +0200 In-Reply-To: <20160715110732.GC9258@mwanda> (Dan Carpenter's message of "Fri, 15 Jul 2016 14:07:32 +0300") Message-ID: <87bn1w1ec3.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter writes: > If we "goto out;" then it calls display_timings_release(timings); > Since "timings" is NULL, that's going to oops. Just return directly. > > Fixes: 420a488278e8 ('video: fbdev: pxafb: initial devicetree conversion') > Signed-off-by: Dan Carpenter Acked-by: Robert Jarzmik Cheers. -- Robert