From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbbK0Dtq (ORCPT ); Thu, 26 Nov 2015 22:49:46 -0500 Received: from ozlabs.org ([103.22.144.67]:59167 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753757AbbK0Dtl (ORCPT ); Thu, 26 Nov 2015 22:49:41 -0500 From: Rusty Russell To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the modules tree In-Reply-To: <20151127122623.06c052fa@canb.auug.org.au> References: <20151127122623.06c052fa@canb.auug.org.au> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 27 Nov 2015 13:27:34 +1030 Message-ID: <87bnagrvxd.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Rothwell writes: > Hi Rusty, > > After merging the modules tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > In file included from include/linux/kexec.h:26:0, > from include/linux/crash_dump.h:5, > from arch/powerpc/platforms/powernv/pci-ioda.c:16: > include/linux/module.h:770:15: error: return type defaults to 'int' [-Werror=return-type] Thanks, this typo hit all archs which don't do RO module protection by default. Maybe PPC should do that? I've fixed it (and some others found by 0-day) and rebased. Thanks, Rusty.