From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: get_vmalloc_info() and /proc/meminfo insanely expensive
Date: Thu, 13 Aug 2015 09:42:52 +0200 [thread overview]
Message-ID: <87bnebk51f.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <CA+55aFzjhAoa6aiEfuwM_XyYn0OWRjUuHyEasfj=q4tzOHFGYA@mail.gmail.com> (Linus Torvalds's message of "Wed, 12 Aug 2015 22:52:44 -0700")
On Thu, Aug 13 2015, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Wed, Aug 12, 2015 at 9:00 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>>
>> Do your /proc/meminfo vmalloc numbers actually change during that build?
>> Mine don't. Perhaps we can cache the most recent vmalloc_info and
>> invalidate that cache whenever someone does a vmalloc/vfree/etc.
>
> Sure, that works too.
>
> Looking at that mm/vmalloc.c file, the locking is pretty odd. It looks
> pretty strange in setup_vmalloc_vm(), for example. If that newly
> allocated "va" that we haven't even exposed to anybody yet has its
> address or size changed, we're screwed in so many ways.
>
> I get the feeling this file should be rewritten. But that's not going
> to happen. The "let's just cache the last value for one jiffy" seemed
> to be the minimal fixup to it.
>
I think it's simpler and better to fix glibc. Looking at the history,
the code for get_[av]phys_pages was added in 1996 (in the git repo
commit 845dcb57), with comments such as
/* Return the number of pages of physical memory in the system. There
is currently (as of version 2.0.21) no system call to determine the
number. It is planned for the 2.1.x series to add this, though.
and
/* XXX Here will come a test for the new system call. */
And that syscall seems to be sysinfo(). So even though sysinfo() also
returns much more than required, it is still more than an order of
magnitude faster than reading and parsing /proc/meminfo (in the quick
microbench I threw together):
#include <stdio.h>
#include <sys/sysinfo.h>
#include <rdtsc.h>
void do_get_phys_pages(void)
{
get_phys_pages();
}
void do_get_avphys_pages(void)
{
get_avphys_pages();
}
void do_sysinfo(void)
{
struct sysinfo info;
sysinfo(&info);
}
void time_this(const char *name, void (*f)(void), int rep)
{
int i;
unsigned long start, stop;
start = rdtsc();
for (i = 0; i < rep; ++i)
f();
stop = rdtsc();
printf("%-20s\t%d\t%lu\t%.1f\n", name, rep, stop-start, (double)(stop-start)/rep);
}
#define time_this(f, rep) time_this(#f, do_ ## f, rep)
int main(void)
{
time_this(sysinfo, 1);
time_this(get_phys_pages, 1);
time_this(get_avphys_pages, 1);
time_this(sysinfo, 1);
time_this(get_phys_pages, 1);
time_this(get_avphys_pages, 1);
time_this(sysinfo, 10);
time_this(get_phys_pages, 10);
time_this(get_avphys_pages, 10);
return 0;
}
$ ./sysinfo
sysinfo 1 6056 6056.0
get_phys_pages 1 226744 226744.0
get_avphys_pages 1 84480 84480.0
sysinfo 1 2288 2288.0
get_phys_pages 1 73216 73216.0
get_avphys_pages 1 76692 76692.0
sysinfo 10 6856 685.6
get_phys_pages 10 626936 62693.6
get_avphys_pages 10 604440 60444.0
Rasmus
next prev parent reply other threads:[~2015-08-13 7:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 3:29 get_vmalloc_info() and /proc/meminfo insanely expensive Linus Torvalds
2015-08-13 4:00 ` Andrew Morton
2015-08-13 5:52 ` Linus Torvalds
2015-08-13 7:42 ` Rasmus Villemoes [this message]
2015-08-13 16:50 ` Linus Torvalds
2015-08-13 18:32 ` Linus Torvalds
2015-08-13 18:52 ` Linus Torvalds
2015-08-13 19:50 ` David Rientjes
2015-08-13 20:04 ` Linus Torvalds
2015-08-13 21:15 ` Tony Luck
2015-08-13 22:56 ` Linus Torvalds
2015-08-13 20:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnebk51f.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).