From: ebiederm@xmission.com (Eric W. Biederman)
To: "Michael Kerrisk \(man-pages\)" <mtk.manpages@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"linux-man\@vger.kernel.org" <linux-man@vger.kernel.org>,
containers@lists.linux-foundation.org,
Andy Lutomirski <luto@amacapital.net>,
richard.weinberger@gmail.com,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: For review: user_namespace(7) man page
Date: Tue, 09 Sep 2014 11:16:08 -0500 [thread overview]
Message-ID: <87bnqon513.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <540F07FD.7010106@gmail.com> (Michael Kerrisk's message of "Tue, 09 Sep 2014 07:00:29 -0700")
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> writes:
> Hi Eric,
>
>> On a related note. One thing that has come up recently (in 3 separate
>> implementations is that mount(MS_REMOUNT|...,...) must include all of
>> the mount flags that need to be preserved. People creating read-only
>> bind mounts tend to miss that and the locked flags in mount namespaces.
>> That issue was flushed out now that the kernel is now not allowing most
>> mount flags to be cleared in mount namespaces.
>
> So, are you meaning that something needs to be added to the page
> regarding this point?
Yes. The interface is non-intuitive and we should at least document
the weirdness.
I recommend updating the mount(2) man page to say something like:
MS_REMOUNT
Remount an existing mount. This allows you to change the
mountflags and data of an existing mount without having
to unmount and remount the file system. target should be
the same value specified in the initial mount() call;
source and filesystemtype are ignored.
^^^^^^^^^^^^^
Mountflags and data should match the original mount system
call except those parameters that are being deliberately
changed.
The following mountflags can be changed: MS_RDONLY,
MS_SYNCHRONOUS, MS_MANDLOCK; before kernel 2.6.16, the
following could also be changed: MS_NOATIME and
MS_NODIRATIME; and, additionally, before kernel 2.4.10,
the following could also be changed: MS_NOSUID, MS_NODEV,
MS_NOEXEC.
Eric
next prev parent reply other threads:[~2014-09-09 16:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 23:36 For review: user_namespace(7) man page Michael Kerrisk (man-pages)
2014-08-22 21:12 ` Serge E. Hallyn
2014-09-01 16:58 ` Michael Kerrisk (man-pages)
2014-08-30 21:53 ` Eric W. Biederman
2014-09-01 17:31 ` Michael Kerrisk (man-pages)
2014-09-02 1:05 ` Eric W. Biederman
2014-09-09 14:00 ` Michael Kerrisk (man-pages)
2014-09-09 16:16 ` Eric W. Biederman [this message]
2014-09-11 14:40 ` Michael Kerrisk (man-pages)
2014-09-09 13:59 ` Michael Kerrisk (man-pages)
2014-09-09 15:49 ` Eric W. Biederman
2014-09-11 14:40 ` Michael Kerrisk (man-pages)
2014-09-09 13:59 ` Michael Kerrisk (man-pages)
2014-09-09 15:51 ` Eric W. Biederman
2014-09-11 14:40 ` Michael Kerrisk (man-pages)
2014-09-01 20:57 ` Andy Lutomirski
2014-09-09 14:00 ` Michael Kerrisk (man-pages)
2014-09-09 16:05 ` Eric W. Biederman
2014-09-09 19:26 ` Andy Lutomirski
2014-09-09 19:39 ` Andy Lutomirski
2014-09-11 14:47 ` Michael Kerrisk (man-pages)
2014-09-11 15:15 ` Andy Lutomirski
2014-09-14 2:58 ` Michael Kerrisk (man-pages)
2014-09-11 14:46 ` Michael Kerrisk (man-pages)
2014-09-11 15:14 ` Andy Lutomirski
2014-09-14 2:42 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnqon513.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mtk.manpages@gmail.com \
--cc=richard.weinberger@gmail.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).