From: Peter Korsgaard <email@example.com> To: "Joseph Chang" <firstname.lastname@example.org> Cc: "'Joseph CHANG'" <email@example.com>, "'Greg Kroah-Hartman'" <firstname.lastname@example.org>, <email@example.com>, <firstname.lastname@example.org>, <email@example.com>, <firstname.lastname@example.org> Subject: Re: [PATCH 1/1] net: add dm9620 net usb driver Date: Fri, 05 Jul 2013 15:49:36 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <201307030548.r635mxI6027578@mail.davicom.com.tw> (Joseph Chang's message of "Wed, 3 Jul 2013 13:49:11 +0800") >>>>> "Joseph" == Joseph Chang <firstname.lastname@example.org> writes: Hi, Joseph> This is Joseph CHANG, I am glade to contact and work with Joseph> you. I am busy in some affairs else these days, and will Joseph> like to be back soon. Joseph> For the begin, We copy the source code 'dm9601.c' which was Joseph> by you, In order to work for our new chips (DM9620, DM9621, Joseph> DM9621A... series), We did modify to get 'dm9620.c' base on Joseph> 'dm0601.c', Since you are the author and also the owner, so Joseph> keep MODULE_AUTHOR() as you. Yes, that's what I learned from a number of bug reports. It would have been good if you would have worked with me to get your modifications integrated instead. Joseph> To generate DM9620.c is a way to distinguish the different Joseph> generation chips: (as below) Joseph> DM9601: old revision: USB1.1, Ethernet 10/100, Phase out Joseph> DM9620: current revision: USB2.0, Ethernet 10/100, Mass production state Joseph> DM9633: next revision: USB3.0, Ethernet 10/100/1000, Will to Joseph> release on 2013/E dm9620 is basically backwards compatible with dm9601, so I added dm9620 support to the dm9601 driver earlier this year: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6642f91c92da0736 Is there anything missing from that? I don't see any dm9633 datasheet on the davicom website, so I cannot say if it makes sense to add support for it in the existing driver. Is the datasheet available somewhere? Joseph> So want to make it from the configuration by "make Joseph> menuconfig". Joseph> Can you help give further advices, we hope you can go ahead Joseph> be the owner (author) of the 'dm9620.c', And then we make patch Joseph> to it. Would you agree this idea? If so we will be happy Joseph> because we did not ever create such a code. Joseph> * Think about DM9633 driver to be, It will be is total Joseph> different compare to DM9601 & DM9620. And will get the same Joseph> issue. If you can provide me with a dm9633 datasheet and a sample device then I can look into writing a driver for it / extending dm9601.c. Please contact me off list for that. Thanks! -- Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-07-05 13:49 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-20 12:20 Joseph CHANG 2013-06-23 20:00 ` Peter Korsgaard 2013-07-03 5:49 ` Joseph Chang 2013-07-05 13:49 ` Peter Korsgaard [this message] -- strict thread matches above, loose matches on Subject: below -- 2013-06-19 12:36 Joseph CHANG 2013-06-19 13:20 ` Andi Shyti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 1/1] net: add dm9620 net usb driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).