From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932299Ab0F3Sdk (ORCPT ); Wed, 30 Jun 2010 14:33:40 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:34831 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756962Ab0F3Sdj (ORCPT ); Wed, 30 Jun 2010 14:33:39 -0400 From: "Aneesh Kumar K. V" To: Latchesar Ionkov Cc: Linus Torvalds , Eric Van Hensbergen , V9FS Developers , Al Viro , linux-kernel Subject: Re: [V9fs-developer] [GIT PULL] 9p file system bug fixes for 2.6.35-rc2 In-Reply-To: References: <20100608004102.GQ31073@ZenIV.linux.org.uk> <87pqzrexon.fsf@linux.vnet.ibm.com> <871vbwe6lp.fsf@linux.vnet.ibm.com> <87mxuc91r2.fsf@linux.vnet.ibm.com> User-Agent: Notmuch/ (http://notmuchmail.org) Emacs/24.0.50.1 (i686-pc-linux-gnu) Date: Thu, 01 Jul 2010 00:03:29 +0530 Message-ID: <87bpas8j5y.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jun 2010 12:16:15 -0600, Latchesar Ionkov wrote: > I think that you need to use the s_vfs_rename_mutex in the super_block > struct instead of introducing a new rename_lock in the v9fs session. > I guess that will have lock dependency issue with inode->i_mutex. Also as Linus suggested with dentry name copied we can avoid holding the lock when doing 9P operation. -aneesh