From: Felipe Balbi <balbi@kernel.org>
To: "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kun.liu2@amd.com,
alexander.deucher@amd.com
Subject: Re: [PATCH 2/2] usb: dwc3: pci add property to allow user space role switch
Date: Tue, 24 Aug 2021 19:17:46 +0300 [thread overview]
Message-ID: <87czq27r5w.fsf@kernel.org> (raw)
In-Reply-To: <1d9ecba4-d180-2193-66a3-3812759e1916@amd.com>
"Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com> writes:
> Hi
> On 8/24/2021 1:49 PM, Felipe Balbi wrote:
>> Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com> writes:
>>
>>> For AMD platform there is a requirement to enable user space role
>>> switch from host to device and device to host by means of running
>>> following commands.
>>>
>>> HOST: echo host > /sys/class/usb_role/dwc3.0.auto-role-switch/role
>>> DEVICE: echo device > /sys/class/usb_role/dwc3.0.auto-role-switch/role
>> A more important question that needs to be answered: why?
>>
> Our customer platform is not completely capable of OTG i.e with type C
> controller it does not have PD to support role switching. Hence, they
> have script which triggers the role switch based on ACPI/EC interrupt.
sounds like some generalized version of this text should be added to
commit log.
--
balbi
next prev parent reply other threads:[~2021-08-24 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 18:44 [PATCH 0/2] Add DWC3 controller suppport for AMD's platforms Nehal Bakulchandra Shah
2021-08-23 18:44 ` [PATCH 1/2] usb: dwc3: pci: add support for AMD's newer generation platform Nehal Bakulchandra Shah
2021-08-24 8:19 ` Felipe Balbi
2021-08-23 18:44 ` [PATCH 2/2] usb: dwc3: pci add property to allow user space role switch Nehal Bakulchandra Shah
2021-08-24 8:19 ` Felipe Balbi
2021-08-24 16:02 ` Shah, Nehal-bakulchandra
2021-08-24 16:17 ` Felipe Balbi [this message]
2021-08-24 16:28 ` Shah, Nehal-bakulchandra
2021-08-24 16:54 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czq27r5w.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=alexander.deucher@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=kun.liu2@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).