From: Nathan Lynch <nathanl@linux.ibm.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH vdsotest] Use vdso wrapper for gettimeofday()
Date: Mon, 13 Apr 2020 11:05:04 -0500 [thread overview]
Message-ID: <87d08b8j7z.fsf@linux.ibm.com> (raw)
In-Reply-To: <1c2c6da1-e10f-d2a8-fc5e-ecf405879df5@c-s.fr>
Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Hi Nathan,
>
> Le 16/01/2020 à 17:56, Nathan Lynch a écrit :
>> Hi Christophe,
>>
>> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>>> To properly handle errors returned by gettimeofday(), the
>>> DO_VDSO_CALL() macro has to be used, otherwise vdsotest
>>> misinterpret VDSO function return on error.
>>>
>>> This has gone unnoticed until now because the powerpc VDSO
>>> gettimeofday() always succeed, but while porting powerpc to
>>> generic C VDSO, the following has been encountered:
>>
>> Thanks for this, I'll review it soon.
>>
>> Can you point me to patches for the powerpc generic vdso work?
>>
>
> I have not seen any update on the vdsotest repository, have you been
> able to have a look at the patch ?
Thanks for the reminder. I've applied this now.
prev parent reply other threads:[~2020-04-13 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 12:19 [PATCH vdsotest] Use vdso wrapper for gettimeofday() Christophe Leroy
2020-01-16 16:56 ` Nathan Lynch
2020-01-16 17:59 ` Christophe Leroy
2020-04-07 16:11 ` Christophe Leroy
2020-04-13 16:05 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d08b8j7z.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).