From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F0BCC35254 for ; Mon, 17 Feb 2020 10:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7322720725 for ; Mon, 17 Feb 2020 10:29:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="NyHWaVkS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729258AbgBQK3C (ORCPT ); Mon, 17 Feb 2020 05:29:02 -0500 Received: from ozlabs.org ([203.11.71.1]:35505 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728698AbgBQK3B (ORCPT ); Mon, 17 Feb 2020 05:29:01 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 48LgFQ6rZlz9sRJ; Mon, 17 Feb 2020 21:28:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1581935339; bh=nEmdpQuucobTW6rpdULzizRAsoI2rsTmZ9yAx2qGur4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NyHWaVkSyuF7cTzcZbwuW426SYGM0A8R3gWMojjCaz5LjwOgg7Rj3F1/oC7p/ONiy fVOHT7y6qbWC1pZwURPjZjLVjYLufuM/MOBJjUcpFyZfZK6JinutuyMOw1UqFEftec 61qlu07DPFeSjZlL/reQfz30XSDIFdJtQ0XGzxqT5TOZgDC1+hNegOvEblHtkQ4pB7 nyISu8uHKRuOpfitYFzzCM9YwRrIAaLgrO8j+USQi57ZnbZWagEoPHlZFgY8kU4/km cRciaA89kOerKA7VsFcU4egklotTxSym5pOge5YOCKwWSTj2xhz0CekhhPruKJuUFk NUFzbkw0aJTdg== From: Michael Ellerman To: Masahiro Yamada Cc: Linux Kernel Mailing List , Linux Kbuild mailing list Subject: Re: install is no longer PHONY? In-Reply-To: References: <874kvz10rx.fsf@mpe.ellerman.id.au> Date: Mon, 17 Feb 2020 21:28:55 +1100 Message-ID: <87d0adfqxk.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masahiro Yamada writes: > Hi Michael, > > On Mon, Feb 10, 2020 at 2:15 PM Michael Ellerman wrote: >> >> Hi Masahiro, >> >> I noticed that "install" seems to be no longer PHONY, or at least if I >> have a file/directory called install then the build doesn't run. >> >> eg: >> $ touch install >> $ make install >> make: 'install' is up to date. >> $ rm install >> $ make install >> LDS arch/powerpc/boot/zImage.lds >> WRAP arch/powerpc/boot/zImage.pseries >> WRAP arch/powerpc/boot/zImage.epapr > > > I think the reason is > 'install' is not specified as a phony target. > > You can add 'PHONY += install' to fix it. > > > PHONY += install # please add this! > install: > $(Q)$(MAKE) $(build)=$(boot) install > > > Please do so in both arch/powerpc/Makefile and > arch/powerpc/boot/Makefile. Oh lol, sorry I didn't realise install was in the arch Makefile. >> In the past the presence of an install file/directory didn't have any >> affect. >> >> It seems this changed in: >> d79424137a73 ("kbuild: do not update config when running install targets") >> >> Was that expected? >> >> cheers > > > I do not think commit is related. > > Prior to this commit, I still see the same issue. > > > $ git checkout d7942413^ > $ touch install > $ make -s ARCH=powerpc allnoconfig > $ make ARCH=powerpc install > make: 'install' is up to date. Hmm weird. I did bisect it: # bad: [d79424137a7312d381d131d707a462440c0e8df9] kbuild: do not update config when running install targets git bisect bad d79424137a7312d381d131d707a462440c0e8df9 # good: [9c2af1c7377a8a6ef86e5cabf80978f3dbbb25c0] kbuild: add .DELETE_ON_ERROR special target git bisect good 9c2af1c7377a8a6ef86e5cabf80978f3dbbb25c0 # first bad commit: [d79424137a7312d381d131d707a462440c0e8df9] kbuild: do not update config when running install targets But you're right. I must have messed something up while bisecting. Sorry for the noise. cheers