linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Will Deacon <will@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	security@kernel.org, ben.dooks@codethink.co.uk
Subject: Re: [PATCH] exec: warn if process starts with executable stack
Date: Wed, 20 Nov 2019 14:28:37 -0600	[thread overview]
Message-ID: <87d0dm47ii.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20191120191752.GC4799@willie-the-truck> (Will Deacon's message of "Wed, 20 Nov 2019 19:17:52 +0000")

Will Deacon <will@kernel.org> writes:

> On Tue, Nov 19, 2019 at 12:52:27AM +0300, Alexey Dobriyan wrote:
>> There were few episodes of silent downgrade to an executable stack:
>> 
>> 1) linking innocent looking assembly file
>> 
>> 	$ cat f.S
>> 	.intel_syntax noprefix
>> 	.text
>> 	.globl f
>> 	f:
>> 	        ret
>> 
>> 	$ cat main.c
>> 	void f(void);
>> 	int main(void)
>> 	{
>> 	        f();
>> 	        return 0;
>> 	}
>> 
>> 	$ gcc main.c f.S
>> 	$ readelf -l ./a.out
>> 	  GNU_STACK      0x0000000000000000 0x0000000000000000 0x0000000000000000
>>                          0x0000000000000000 0x0000000000000000  RWE    0x10
>> 
>> 2) converting C99 nested function into a closure
>> https://nullprogram.com/blog/2019/11/15/
>> 
>> 	void intsort2(int *base, size_t nmemb, _Bool invert)
>> 	{
>> 	    int cmp(const void *a, const void *b)
>> 	    {
>> 	        int r = *(int *)a - *(int *)b;
>> 	        return invert ? -r : r;
>> 	    }
>> 	    qsort(base, nmemb, sizeof(*base), cmp);
>> 	}
>> 
>> will silently require stack trampolines while non-closure version will not.
>> 
>> While without a double this behaviour is documented somewhere, add a warning
>> so that developers and users can at least notice. After so many years of x86_64
>> having proper executable stack support it should not cause too much problems.
>> 
>> If the system is old or CPU is old, then there will be an early warning
>> against init and/or support personnel will write that "uh-oh, our Enterprise
>> Software absolutely requires executable stack" and close tickets and customers
>> will nod heads and life moves on.
>> 
>> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>> ---
>> 
>>  fs/exec.c |    5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> --- a/fs/exec.c
>> +++ b/fs/exec.c
>> @@ -762,6 +762,11 @@ int setup_arg_pages(struct linux_binprm *bprm,
>>  		goto out_unlock;
>>  	BUG_ON(prev != vma);
>>  
>> +	if (vm_flags & VM_EXEC) {
>> +		pr_warn_once("process '%s'/%u started with executable stack\n",
>> +			     current->comm, current->pid);
>> +	}
>
> Given that this is triggerable by userspace, is there a concern about PID
> namespaces here?

In what sense?  Are you thinking about the printing of the pid?

Pretty much by fiat and by definition the kernel log always print things
in the initial pid namespace.  Which this printk does.

Eric

  reply	other threads:[~2019-11-20 20:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 14:51 [PATCH] ELF: " Alexey Dobriyan
2019-11-18 17:13 ` Ben Dooks
2019-11-18 20:54 ` Andrew Morton
2019-11-18 21:36   ` Alexey Dobriyan
2019-11-18 21:52   ` [PATCH] exec: " Alexey Dobriyan
2019-11-19  5:32     ` Dan Carpenter
2019-11-20 19:17     ` Will Deacon
2019-11-20 20:28       ` Eric W. Biederman [this message]
2019-11-21  9:38         ` Will Deacon
2019-12-08 16:43           ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0dm47ii.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=will@kernel.org \
    --subject='Re: [PATCH] exec: warn if process starts with executable stack' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).