From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7081FC43381 for ; Wed, 13 Mar 2019 06:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D3B62075C for ; Wed, 13 Mar 2019 06:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbfCMG52 (ORCPT ); Wed, 13 Mar 2019 02:57:28 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:7547 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726125AbfCMG52 (ORCPT ); Wed, 13 Mar 2019 02:57:28 -0400 Date: 13 Mar 2019 15:57:25 +0900 X-IronPort-AV: E=Sophos;i="5.58,473,1544454000"; d="scan'208";a="10018063" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 13 Mar 2019 15:57:25 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id A8420402A734; Wed, 13 Mar 2019 15:57:25 +0900 (JST) Message-ID: <87d0mvgtnc.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Cc: Jiada Wang , , , , , , , , , , , , Subject: Re: [PATCH 5/5] ASoC: rsnd: dma: use extended audio dmac registers when available In-Reply-To: References: <20190313055811.26135-1-jiada_wang@mentor.com> <87h8c7gv73.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon > > 2nd, in my understanding, our conclusion at Renesas-ML > > is that we don't need to think about basic/extend DMAC register. > > Because extend area is 100% covering basic area. > > In other words, it is compatible. > > Driver side don't need to think about it. > > > I am a little confused, > because latest comment received from simon, suggests to let driver to > decide which register set to use. > > for me, I think it's not necessary, if extended register set is available, > driver shall always use it. I can agree to have both basic/extend register if driver need to switch its behavior. But this case, there is nothing to do on driver side. In other words, SoC always need to use extend register if it has. I don't know why datasheet is indicating both area. Maybe it is because for Gen3 all-in ? I'm not sure. Anyway, Simon, can you agree about it ? Having both basic/extend register is just noise for driver. Best regards --- Kuninori Morimoto