From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] kernel/hung_task.c: disable on suspend
Date: Fri, 14 Sep 2018 16:19:52 +0200 [thread overview]
Message-ID: <87d0tg88l3.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <4793718.OcKebjM5bH@aspire.rjw.lan> (Rafael J. Wysocki's message of "Fri, 14 Sep 2018 13:26:13 +0200")
"Rafael J. Wysocki" <rjw@rjwysocki.net> writes:
> On Thursday, September 13, 2018 6:08:51 PM CEST Vitaly Kuznetsov wrote:
...
>> +static int hungtask_pm_notify(struct notifier_block *self,
>> + unsigned long action, void *hcpu)
>> +{
>> + switch (action) {
>> + case PM_SUSPEND_PREPARE:
>> + case PM_HIBERNATION_PREPARE:
>> + hung_detector_suspended = true;
>> + break;
>> + case PM_POST_SUSPEND:
>> + case PM_POST_HIBERNATION:
>> + hung_detector_suspended = false;
>> + break;
>> + default:
>> + break;
>> + }
>> + return NOTIFY_OK;
>> +}
>> +
>> /*
>> * kthread which checks for tasks stuck in D state
>> */
>> @@ -261,7 +282,8 @@ static int watchdog(void *dummy)
>> interval = min_t(unsigned long, interval, timeout);
>> t = hung_timeout_jiffies(hung_last_checked, interval);
>
> Since you are adding the notifier anyway, what about designing it to make
> the thread wait on _PREPARE until the notifier kicks it again on exit
> fron suspend/hibernation?
>
We can either park the kthread (kthread_park/unpark) or make it go away
completely by doing kthread_stop/kthread_run(). I'm leaning toward
parking, what do you think?
--
Vitaly
next prev parent reply other threads:[~2018-09-14 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 16:08 [PATCH] kernel/hung_task.c: disable on suspend Vitaly Kuznetsov
2018-09-14 11:26 ` Rafael J. Wysocki
2018-09-14 14:19 ` Vitaly Kuznetsov [this message]
2018-09-14 16:21 ` Oleg Nesterov
2018-09-17 8:25 ` Rafael J. Wysocki
2018-09-17 16:55 ` Oleg Nesterov
2018-09-17 21:09 ` Rafael J. Wysocki
2018-09-21 13:11 ` Vitaly Kuznetsov
2018-09-21 13:15 ` Rafael J. Wysocki
2018-09-21 15:18 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0tg88l3.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).