From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751097AbdGYJJc (ORCPT ); Tue, 25 Jul 2017 05:09:32 -0400 Received: from ozlabs.org ([103.22.144.67]:40065 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbdGYJJb (ORCPT ); Tue, 25 Jul 2017 05:09:31 -0400 From: Michael Ellerman To: Dou Liyang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Cc: Dou Liyang , David Rientjes , Michal Hocko , isimatu.yasuaki@jp.fujitsu.com Subject: Re: [PATCH v2] mm: Drop useless local parameters of __register_one_node() In-Reply-To: <1498013846-20149-1-git-send-email-douly.fnst@cn.fujitsu.com> References: <1498013846-20149-1-git-send-email-douly.fnst@cn.fujitsu.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 25 Jul 2017 19:09:29 +1000 Message-ID: <87d18o7uie.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dou Liyang writes: > ... initializes local parameters "p_node" & "parent" for > register_node(). > > But, register_node() does not use them. > > Remove the related code of "parent" node, cleanup __register_one_node() > and register_node(). > > Cc: Andrew Morton > Cc: David Rientjes > Cc: Michal Hocko > Cc: isimatu.yasuaki@jp.fujitsu.com > Signed-off-by: Dou Liyang > Acked-by: David Rientjes > --- > V1 --> V2: > Rebase it on > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm > > drivers/base/node.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) That appears to be the last user of parent_node(). Can we start removing it from the topology.h headers for each arch? cheers