From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762656AbdAIQc7 (ORCPT ); Mon, 9 Jan 2017 11:32:59 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:47730 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbdAIQc6 (ORCPT ); Mon, 9 Jan 2017 11:32:58 -0500 From: Vivien Didelot To: Randy Dunlap , Florian Fainelli , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn , Jiri Pirko Subject: Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV In-Reply-To: <336a46c0-705a-9cf0-1a0d-447af28893bb@infradead.org> References: <20170108231724.27398-1-vivien.didelot@savoirfairelinux.com> <336a46c0-705a-9cf0-1a0d-447af28893bb@infradead.org> Date: Mon, 09 Jan 2017 11:32:35 -0500 Message-ID: <87d1fwurbw.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, Randy Dunlap writes: > On 01/08/17 17:18, Florian Fainelli wrote: >> On 01/08/2017 03:17 PM, Vivien Didelot wrote: >>> DSA wraps SWITCHDEV, thus select it instead of depending on it. >>> >>> Signed-off-by: Vivien Didelot >> >> Reviewed-by: Florian Fainelli >> > > but when CONFIG_INET is not enabled, the patch causes this warning: > > warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET) Thanks for spotting that! Would that be enough to change this first? diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig index 675acbf1502d..c7263b70e72b 100644 --- a/net/dsa/Kconfig +++ b/net/dsa/Kconfig @@ -1,6 +1,6 @@ config HAVE_NET_DSA def_bool y - depends on NETDEVICES && !S390 + depends on INET && NETDEVICES && !S390 # Drivers must select NET_DSA and the appropriate tagging format Thanks, Vivien