From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757971AbcJHJ2E (ORCPT ); Sat, 8 Oct 2016 05:28:04 -0400 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:17408 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbcJHJ15 (ORCPT ); Sat, 8 Oct 2016 05:27:57 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 08 Oct 2016 11:27:54 +0200 X-ME-IP: 90.5.140.104 From: Robert Jarzmik To: Daniel Mack Cc: Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: pxa: pxa_cplds: honor probe deferral References: <1474874488-26533-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 08 Oct 2016 11:27:54 +0200 In-Reply-To: <1474874488-26533-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Mon, 26 Sep 2016 09:21:28 +0200") Message-ID: <87d1jb8a1x.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > The method to acquire the input interrupt was working in a platform data > based board, but was failing in a device-tree one when the gpio > controller was probed after pxa_cplds. > > Use platform_get_irq() to benefit from the probe deferral > mechanism. Moreover, as seen in dm9000.c development, platform_get_irq() > doesn't honor the irq type IO resource (ie. edge rising for example), > and it must be passed again at irq request in a not device-tree build, > hence the irq_get_trigger_type() call. > > Signed-off-by: Robert Jarzmik Applied to pxa/for-next. Cheers. -- Robert