From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: vince@deater.net, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, eranian@google.com,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks
Date: Mon, 29 Aug 2016 17:43:51 +0300 [thread overview]
Message-ID: <87d1krljo8.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20160829141437.GU10153@twins.programming.kicks-ass.net>
Peter Zijlstra <peterz@infradead.org> writes:
> On Wed, Aug 24, 2016 at 05:15:54PM +0300, Alexander Shishkin wrote:
>> @@ -221,10 +245,13 @@ static void __bts_event_start(struct perf_event *event)
>>
>> /*
>> * local barrier to make sure that ds configuration made it
>> - * before we enable BTS
>> + * before we enable BTS and bts::state goes ACTIVE
>> */
>> wmb();
>>
>> + /* INACTIVE/STOPPED -> ACTIVE */
>> + WRITE_ONCE(bts->state, BTS_STATE_ACTIVE);
>> +
>> intel_pmu_enable_bts(config);
>>
>> }
>
> Alexander, were you going to post a new version of this patch without
> the barrier confusion?
Yes, only the testcase exploded again over the weekend, looking at it
again.
Regards,
--
Alex
next prev parent reply other threads:[~2016-08-29 14:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 8:54 [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Alexander Shishkin
2016-08-23 8:54 ` [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks Alexander Shishkin
2016-08-24 12:28 ` Alexander Shishkin
2016-08-24 14:15 ` Alexander Shishkin
2016-08-26 20:49 ` Vince Weaver
2016-08-27 6:35 ` Alexander Shishkin
2016-08-29 14:14 ` Peter Zijlstra
2016-08-29 14:43 ` Alexander Shishkin [this message]
2016-08-23 8:54 ` [PATCH 2/3] perf/x86/intel/bts: Kill a silly warning Alexander Shishkin
2016-08-23 8:54 ` [PATCH 3/3] perf: Fix a race between mmap_close and set_output of AUX events Alexander Shishkin
2016-08-23 16:24 ` [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Vince Weaver
2016-08-23 17:10 ` Alexander Shishkin
2016-08-23 20:55 ` Vince Weaver
2016-08-24 3:44 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1krljo8.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=acme@infradead.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).