From: Jani Nikula <jani.nikula@linux.intel.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/gma500: dont expose bytes from kernel stack
Date: Mon, 22 Aug 2016 11:32:46 +0300 [thread overview]
Message-ID: <87d1l1urtd.fsf@intel.com> (raw)
In-Reply-To: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de>
On Sun, 21 Aug 2016, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Components m1, m2, p2, dot, vco of variable clock should be
> initialized to avoid bytes from the kernel stack to be
> exposed.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> index da9fd34..28bd8f3 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> @@ -138,6 +138,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit,
> u32 target_vco, actual_freq;
> s32 freq_error, min_error = 100000;
>
> + memset(clock, 0, sizeof(struct gma_clock_t));
Did you build this? Did you run this?
BR,
Jani.
> memset(best_clock, 0, sizeof(*best_clock));
>
> for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2016-08-22 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 18:39 [PATCH] drm/gma500: dont expose bytes from kernel stack Heinrich Schuchardt
2016-08-21 18:46 ` Joe Perches
2016-08-21 19:35 ` Heinrich Schuchardt
2016-08-21 19:38 ` Joe Perches
2016-08-22 7:29 ` Daniel Vetter
2016-08-22 9:16 ` One Thousand Gnomes
2016-08-22 8:32 ` Jani Nikula [this message]
2016-08-22 13:45 ` kbuild test robot
2016-08-22 17:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1l1urtd.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).