From: Marc Zyngier <marc.zyngier@arm.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jiang Liu <jiang.liu@linux.intel.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <Pawel.Moll@arm.com>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
"hc.yen\@mediatek.com" <hc.yen@mediatek.com>,
"srv_heupstream\@mediatek.com" <srv_heupstream@mediatek.com>,
"yh.chen\@mediatek.com" <yh.chen@mediatek.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"grant.likely\@linaro.org" <grant.likely@linaro.org>,
Yijing Wang <wangyijing@huawei.com>,
Rob Herring <robh+dt@kernel.org>,
"nathan.chung\@mediatek.com" <nathan.chung@mediatek.com>,
"yingjoe.chen\@gmail.com" <yingjoe.chen@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"eddie.huang\@mediatek.com" <eddie.huang@mediatek.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Sascha Hauer <kernel@pengutronix.de>,
"linux- arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi
Date: Wed, 19 Nov 2014 17:49:49 +0000 [thread overview]
Message-ID: <87d28jaxmq.fsf@approximate.cambridge.arm.com> (raw)
In-Reply-To: <1416406451-4578-4-git-send-email-yingjoe.chen@mediatek.com> (Yingjoe Chen's message of "Wed, 19 Nov 2014 14:14:10 +0000")
On Wed, Nov 19 2014 at 2:14:10 pm GMT, Yingjoe Chen <yingjoe.chen@mediatek.com> wrote:
> Add sysirq settings for mt6589/mt8135/mt8127
> This also correct timer interrupt flag. The old setting works
> because boot loader already set polarity for timer interrupt.
> Without intpol support, the setting was not changed so gic
> can get the irq correctly.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> ---
> arch/arm/boot/dts/mt6589.dtsi | 14 ++++++++++++--
> arch/arm/boot/dts/mt8127.dtsi | 14 ++++++++++++--
> arch/arm/boot/dts/mt8135.dtsi | 14 ++++++++++++--
> 3 files changed, 36 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mt6589.dtsi b/arch/arm/boot/dts/mt6589.dtsi
> index e3c7600..c91b2a9 100644
> --- a/arch/arm/boot/dts/mt6589.dtsi
> +++ b/arch/arm/boot/dts/mt6589.dtsi
> @@ -19,7 +19,7 @@
>
> / {
> compatible = "mediatek,mt6589";
> - interrupt-parent = <&gic>;
> + interrupt-parent = <&sysirq>;
This worries me a bit. Your sysirq cannot handle PPIs, and yet you make
it the top-level interrupt controller, without amending any PPI.
Does it mean you do not use *any* PPI? No per-cpu timer, nothing?
Thanks,
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2014-11-19 17:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 14:14 [PATCH v7 0/4] ARM: mediatek: Add support for interrupt polarity Yingjoe Chen
2014-11-19 14:14 ` [PATCH v7 1/4] irqchip: gic: Support hierarchy irq domain Yingjoe Chen
2014-11-19 17:18 ` Marc Zyngier
2014-11-20 3:57 ` Yingjoe Chen
2014-11-20 9:41 ` Yingjoe Chen
2014-11-20 10:29 ` Marc Zyngier
2014-11-20 4:26 ` Jiang Liu
2014-11-20 10:07 ` Marc Zyngier
2014-11-21 15:51 ` Yingjoe Chen
2014-11-24 19:31 ` Marc Zyngier
2014-11-19 14:14 ` [PATCH v7 2/4] ARM: mediatek: Add sysirq interrupt polarity support Yingjoe Chen
2014-11-19 18:04 ` Mark Rutland
2014-11-21 15:36 ` Yingjoe Chen
2014-11-19 14:14 ` [PATCH v7 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Yingjoe Chen
2014-11-19 17:49 ` Marc Zyngier [this message]
2014-11-20 3:29 ` Yingjoe Chen
2014-11-19 14:14 ` [PATCH v7 4/4] dt-bindings: add bindings for mediatek sysirq Yingjoe Chen
2014-11-19 18:07 ` Mark Rutland
2014-11-24 15:14 ` Yingjoe Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d28jaxmq.fsf@approximate.cambridge.arm.com \
--to=marc.zyngier@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=bhelgaas@google.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=grant.likely@linaro.org \
--cc=hc.yen@mediatek.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=nathan.chung@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=wangyijing@huawei.com \
--cc=yh.chen@mediatek.com \
--cc=yingjoe.chen@gmail.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).