From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <chao@kernel.org>
Subject: Re: [PATCH RFC] f2fs: don't inline compressed inode
Date: Thu, 26 Mar 2020 17:35:03 +0800 [thread overview]
Message-ID: <87d715d0-a5c4-7b54-95bb-9b627d163271@huawei.com> (raw)
In-Reply-To: <20200325155806.GC65658@google.com>
On 2020/3/25 23:58, Jaegeuk Kim wrote:
> On 03/25, Chao Yu wrote:
>> f2fs_may_inline_data() only check compressed flag on current inode
>> rather than on parent inode, however at this time compressed flag
>> has not been inherited yet.
>
> When write() or other allocation happens, it'll be reset.
Yeah, all tests are fine w/o this RFC patch, anyway, will let you know if
I find something incompatible.
Thanks,
>
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>>
>> Jaegeuk,
>>
>> I'm not sure about this, whether inline_data flag can be compatible with
>> compress flag, thoughts?
>>
>> fs/f2fs/namei.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
>> index f54119da2217..3807d1b4c4bc 100644
>> --- a/fs/f2fs/namei.c
>> +++ b/fs/f2fs/namei.c
>> @@ -86,7 +86,8 @@ static struct inode *f2fs_new_inode(struct inode *dir, umode_t mode)
>> if (test_opt(sbi, INLINE_XATTR))
>> set_inode_flag(inode, FI_INLINE_XATTR);
>>
>> - if (test_opt(sbi, INLINE_DATA) && f2fs_may_inline_data(inode))
>> + if (test_opt(sbi, INLINE_DATA) && f2fs_may_inline_data(inode) &&
>> + !f2fs_compressed_file(dir))
>> set_inode_flag(inode, FI_INLINE_DATA);
>> if (f2fs_may_inline_dentry(inode))
>> set_inode_flag(inode, FI_INLINE_DENTRY);
>> --
>> 2.18.0.rc1
> .
>
prev parent reply other threads:[~2020-03-26 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:27 [PATCH RFC] f2fs: don't inline compressed inode Chao Yu
2020-03-25 15:58 ` Jaegeuk Kim
2020-03-26 9:35 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d715d0-a5c4-7b54-95bb-9b627d163271@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).