From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB98C433E6 for ; Wed, 3 Feb 2021 01:57:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7AB964F6A for ; Wed, 3 Feb 2021 01:57:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231514AbhBCB4s (ORCPT ); Tue, 2 Feb 2021 20:56:48 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12009 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231319AbhBCB4q (ORCPT ); Tue, 2 Feb 2021 20:56:46 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DVl9d6GdbzjHrd; Wed, 3 Feb 2021 09:54:45 +0800 (CST) Received: from [10.174.178.147] (10.174.178.147) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Wed, 3 Feb 2021 09:56:02 +0800 Subject: Re: [PATCH v2 3/5] ACPI: button: Clean up printing messages To: "Rafael J. Wysocki" , Linux ACPI CC: Linux PM , LKML , "Rafael J. Wysocki" , Zhang Rui , Hans de Goede , Erik Kaneda , "Joe Perches" References: <2367702.B5bJTmGzJm@kreacher> <1991501.dpTHplkurC@kreacher> <1735040.lGk2htMl04@kreacher> From: Hanjun Guo Message-ID: <87d81a42-205d-ec4e-c308-f2a96f56f96c@huawei.com> Date: Wed, 3 Feb 2021 09:56:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1735040.lGk2htMl04@kreacher> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.147] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/3 2:17, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Replace the ACPI_DEBUG_PRINT() instance in button.c with an > acpi_handle_debug() call, drop the _COMPONENT and ACPI_MODULE_NAME() > definitions that are not used any more, drop the no longer needed > ACPI_BUTTON_COMPONENT definition from the headers and update the > documentation accordingly. > > While at it, replace the direct printk() invocations with pr_info() > (that changes the excessive log level for some of them too) and drop > the unneeded PREFIX sybmbol definition from battery.c. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Hanjun Guo