Re: [PATCH v5 0/8] Support ROHM BU27034 ALS sensor

From: Javier Martinez Canillas <javierm@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Shreeya Patel" <shreeya.patel@collabora.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	devicetree@vger.kernel.org,
	"Zhigang Shi" <Zhigang.Shi@liteon.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Paul Gazzillo" <paul@pgazz.com>,
	"Maxime Ripard" <maxime@cerno.tech>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Emma Anholt" <emma@anholt.net>,
	"Liam Beguin" <liambeguin@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David Gow" <davidgow@google.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Brendan Higgins" <brendan.higgins@linux.dev>,
	"David Airlie" <airlied@gmail.com>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 0/8] Support ROHM BU27034 ALS sensor
Date: Wed, 22 Mar 2023 11:34:38 +0100	[thread overview]
Message-ID: <87edphnkg1.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <ZBrSCYp+QrHK47dS@smile.fi.intel.com>

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

Hello Andy,

> On Wed, Mar 22, 2023 at 11:05:23AM +0200, Matti Vaittinen wrote:
>
>> Revision history:
>> v4 => v5: Mostly fixes to review comments from Andy and Jonathan.
>> - more accurate change-log in individual patches
>
>> - copy code from DRM test helper instead of moving it to simplify
>>   merging
>
> 1) Why do you think this is a problem?
> 2) How would we avoid spreading more copies of the same code in the future?
>
>
> 1) Merge conflicts is not a bad thing. It shows that people tested their code
> in isolation and stabilized it before submitting to the upper maintainer.
>
> https://yarchive.net/comp/linux/git_merges_from_upstream.html
>
> 2) Spreading the same code when we _know_ this, should be very well justified.
> Merge conflict is an administrative point, and not a technical obstacle to
> avoid.
>

I believe this was suggested by Maxime and the rationale is that by just
copying the helpers for now, that would make it easier to land instead of
requiring coordination between different subystems.

Otherwise the IIO tree will need to provide an inmutable branch for the
DRM tree to merge and so on.

I agree with Maxime that a little bit of duplication (that can be cleaned
up by each subsystem at their own pace) is the path of least resistance.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat