From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83610C43217 for ; Thu, 20 Oct 2022 10:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbiJTKgS (ORCPT ); Thu, 20 Oct 2022 06:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbiJTKgN (ORCPT ); Thu, 20 Oct 2022 06:36:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C035130D41; Thu, 20 Oct 2022 03:36:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3042E61A94; Thu, 20 Oct 2022 10:36:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1F5BC433D6; Thu, 20 Oct 2022 10:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666262170; bh=TxJ5faWpbSfa0bETdnEE+/lmvNhhQlgn0Q1+RqtkgiY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UGhaIyUdMBPik/GWxDGCyS1WX15SOg21/WbfqPP3J5I6dnFS7sRoqaAOdy9NrbgNY JgzfeIBRf4gfWvYY5RNBt+6g6aT8I9jNGQso/I3dz22ChYf7y6H5St/UQ32qNP84/j bQ46DjtQIo9lmHG/z3uzcE4qV2O75zcf33deVedAcFN5vOQN7PuI7cHpj+iBHs3nSk oZKzRrQ9TaUDEB9+jsIKP4mQc41Q1V3Re6eCtr5d38mHKQBHTB0fMi5l9eaYN08qRb c1iSheflwdyZzCpKiDg5ftVVJViP+8D8/u+WutLuDHSK9twuhsEg2sFJcLkA7x2C3O qSzFSdHzaqRDA== From: Kalle Valo To: Stanislaw Gruszka Cc: "Jason A. Donenfeld" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Andy Shevchenko , Helmut Schaa Subject: Re: [PATCH v3] wifi: rt2x00: use explicitly signed or unsigned types References: <20221019155541.3410813-1-Jason@zx2c4.com> <20221020102920.GA95289@wp.pl> Date: Thu, 20 Oct 2022 13:36:03 +0300 In-Reply-To: <20221020102920.GA95289@wp.pl> (Stanislaw Gruszka's message of "Thu, 20 Oct 2022 12:29:20 +0200") Message-ID: <87edv23hpo.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stanislaw Gruszka writes: > On Wed, Oct 19, 2022 at 09:55:41AM -0600, Jason A. Donenfeld wrote: >> On some platforms, `char` is unsigned, but this driver, for the most >> part, assumed it was signed. In other places, it uses `char` to mean an >> unsigned number, but only in cases when the values are small. And in >> still other places, `char` is used as a boolean. Put an end to this >> confusion by declaring explicit types, depending on the context. >> >> Cc: Andrew Morton >> Cc: Andy Shevchenko >> Cc: Stanislaw Gruszka >> Cc: Helmut Schaa >> Cc: Kalle Valo >> Signed-off-by: Jason A. Donenfeld > > Acked-by: Stanislaw Gruszka Thanks, I'll queue this to v6.1. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches