From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 448B4C43214 for ; Fri, 6 Aug 2021 12:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CF2C61164 for ; Fri, 6 Aug 2021 12:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343740AbhHFMfm (ORCPT ); Fri, 6 Aug 2021 08:35:42 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:15845 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343726AbhHFMfk (ORCPT ); Fri, 6 Aug 2021 08:35:40 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1628253325; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=N2y4oRCNfmsOR5AcLj7KTqZExbR4TqZaeaiHeBAWq7o=; b=M7590IRswx6ENvjU4ImqR90UPbfjcWCRx/3eSpuPm4i5vB6zdO7vbKgQF3B23sw7KfMZ06Hy 01SoasJMkf0E1fhx+GgEny733KSUFn3rc7Fp3lQEClUyH4YaVZqkhnqMgQnkryTXc+iG3n1U NfHArYAqUDqffSUKxgz9k7z3v5U= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 610d2c815c73bba6fbbc3542 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 06 Aug 2021 12:35:13 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 81AB6C43145; Fri, 6 Aug 2021 12:35:12 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D3A5AC433F1; Fri, 6 Aug 2021 12:35:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D3A5AC433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Colin Ian King Cc: Arend van Spriel , Linus Walleij , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "David S . Miller" , Jakub Kicinski , linux-wireless , brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev , kernel-janitors@vger.kernel.org, linux-kernel Subject: Re: [PATCH][next] brcmfmac: firmware: Fix uninitialized variable ret References: <20210803150904.80119-1-colin.king@canonical.com> <875ywkc80d.fsf@codeaurora.org> <96709926-30c6-457e-3e80-eb7ad6e9d778@broadcom.com> Date: Fri, 06 Aug 2021 15:35:05 +0300 In-Reply-To: (Colin Ian King's message of "Fri, 6 Aug 2021 12:28:29 +0100") Message-ID: <87eeb6bvk6.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin Ian King writes: > On 06/08/2021 12:23, Arend van Spriel wrote: >> On 05-08-2021 15:53, Kalle Valo wrote: >>> Linus Walleij writes: >>> >>>> On Tue, Aug 3, 2021 at 5:09 PM Colin King >>>> wrote: >>>> >>>>> From: Colin Ian King >>>>> >>>>> Currently the variable ret is uninitialized and is only set if >>>>> the pointer alt_path is non-null. Fix this by ininitializing ret >>>>> to zero. >>>>> >>>>> Addresses-Coverity: ("Uninitialized scalar variable") >>>>> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware >>>>> binaries") >>>>> Signed-off-by: Colin Ian King >>>> >>>> Nice catch! >>>> Reviewed-by: Linus Walleij >>> >>> I assume this will be fixed by Linus' patch "brcmfmac: firmware: Fix >>> firmware loading" and I should drop Colin's patch, correct? >> >> That would be my assumption as well, but not sure when he will submit >> another revision of it. You probably know what to do ;-) > > I'd prefer my patch to be dropped in preference to Linus' fix. Ok, I'll then drop Colin's patch. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches