From: Jonathan Corbet <corbet@lwn.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs: fault-injection: fix non-working usage of negative values
Date: Mon, 14 Jun 2021 15:58:49 -0600 [thread overview]
Message-ID: <87eed4152e.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210603125841.27436-1-wsa+renesas@sang-engineering.com>
Wolfram Sang <wsa+renesas@sang-engineering.com> writes:
> Fault injection uses debugfs in a way that the provided values via sysfs
> are interpreted as u64. Providing negative numbers results in an error:
>
> /sys/kernel/debug/fail_function# echo -1 > times
> sh: write error: Invalid argument
>
> Update the docs and examples to use "printf %#x <val>" in these cases.
> For "retval", reword the paragraph a little and fix a typo.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> .../fault-injection/fault-injection.rst | 24 +++++++++++--------
> 1 file changed, 14 insertions(+), 10 deletions(-)
Applied, thanks.
jon
prev parent reply other threads:[~2021-06-14 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 12:58 [PATCH] docs: fault-injection: fix non-working usage of negative values Wolfram Sang
2021-06-03 13:27 ` Geert Uytterhoeven
2021-06-03 15:35 ` Wolfram Sang
2021-06-14 21:58 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eed4152e.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akinobu.mita@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).