From: Lars Povlsen <lars.povlsen@microchip.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Lars Povlsen <lars.povlsen@microchip.com>,
Jean Delvare <jdelvare@suse.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
<linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v2 0/3] hwmon: Adding support for Microchip Sparx5 SoC
Date: Wed, 10 Jun 2020 09:33:58 +0200 [thread overview]
Message-ID: <87eeqnidcp.fsf@soft-dev15.microsemi.net> (raw)
In-Reply-To: <5f006733-52b6-e003-5db3-2ff16596918c@roeck-us.net>
Guenter Roeck writes:
> On 6/9/20 12:28 AM, Lars Povlsen wrote:
>> This is an add-on series to the main SoC Sparx5 series
>> (Message-ID: <20200608123024.5330-1-lars.povlsen@microchip.com>)
>>
>> Changes in v2:
>> - Changes in driver as per review comments
>>
>
> And you expect the reviewers/maintainers to remember what those were ?
>
Well, I can see that this might not be the case. I'll be a little more
specific next time. Sorry about that.
For the record, it was:
- Removed unnecessary #includes
- Statement reordering in s5_read()
- Replaced EINVAL with EIO
- Add 'break' in default: case statement.
- Removed extra ()
- Removed superfluous initialization
I got some more comments from Jonathan Cameron
<Jonathan.Cameron@huawei.com>, so there will be another round.
Thanks,
---Lars
>> Lars Povlsen (3):
>> dt-bindings: hwmon: Add Sparx5 temperature sensor
>> arm64: dts: sparx5: Add hwmon temperature sensor
>> hwmon: sparx5: Add Sparx5 SoC temperature driver
>>
>> .../bindings/hwmon/microchip,sparx5-temp.yaml | 39 +++++
>> arch/arm64/boot/dts/microchip/sparx5.dtsi | 6 +
>> drivers/hwmon/Kconfig | 10 ++
>> drivers/hwmon/Makefile | 2 +-
>> drivers/hwmon/sparx5-temp.c | 152 ++++++++++++++++++
>> 5 files changed, 208 insertions(+), 1 deletion(-)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
>> create mode 100644 drivers/hwmon/sparx5-temp.c
>>
>> --
>> 2.27.0
>>
--
Lars Povlsen,
Microchip
prev parent reply other threads:[~2020-06-10 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 7:28 [PATCH v2 0/3] hwmon: Adding support for Microchip Sparx5 SoC Lars Povlsen
2020-06-09 7:48 ` [PATCH v2 1/3] dt-bindings: hwmon: Add Sparx5 temperature sensor Lars Povlsen
2020-06-09 7:49 ` [PATCH v2 2/3] arm64: dts: sparx5: Add hwmon " Lars Povlsen
2020-06-09 7:49 ` [PATCH v2 3/3] hwmon: sparx5: Add Sparx5 SoC temperature driver Lars Povlsen
2020-06-09 8:38 ` Jonathan Cameron
2020-06-09 12:20 ` Lars Povlsen
2020-06-09 13:03 ` Jonathan Cameron
2020-06-09 12:54 ` Lars Povlsen
2020-06-09 13:50 ` [PATCH v2 0/3] hwmon: Adding support for Microchip Sparx5 SoC Guenter Roeck
2020-06-10 7:33 ` Lars Povlsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeqnidcp.fsf@soft-dev15.microsemi.net \
--to=lars.povlsen@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).