From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8106DC43382 for ; Tue, 25 Sep 2018 00:49:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F252320C0A for ; Tue, 25 Sep 2018 00:49:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F252320C0A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727388AbeIYGxo (ORCPT ); Tue, 25 Sep 2018 02:53:44 -0400 Received: from ozlabs.org ([203.11.71.1]:42357 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbeIYGxo (ORCPT ); Tue, 25 Sep 2018 02:53:44 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 42K2WP3Z5Kz9s9N; Tue, 25 Sep 2018 10:48:49 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Arnd Bergmann , Firoz Khan Cc: linuxppc-dev , Benjamin Herrenschmidt , Paul Mackerras , linuxram@us.ibm.com, leitao@debian.org, Boqun Feng , gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz Subject: Re: [PATCH 2/3] powerpc: Add system call table generation support In-Reply-To: References: <1536913980-4811-1-git-send-email-firoz.khan@linaro.org> <1536913980-4811-3-git-send-email-firoz.khan@linaro.org> Date: Tue, 25 Sep 2018 10:48:49 +1000 Message-ID: <87efdi5rm6.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > On Tue, Sep 18, 2018 at 2:15 PM Firoz Khan wrote: >> On 14 September 2018 at 15:31, Arnd Bergmann wrote: >> > On Fri, Sep 14, 2018 at 10:33 AM Firoz Khan wrote: >> > >> >> --- >> >> arch/powerpc/kernel/syscalls/Makefile | 51 ++++ >> >> arch/powerpc/kernel/syscalls/syscall_32.tbl | 378 ++++++++++++++++++++++++++++ >> >> arch/powerpc/kernel/syscalls/syscall_64.tbl | 372 +++++++++++++++++++++++++++ >> >> arch/powerpc/kernel/syscalls/syscallhdr.sh | 37 +++ >> >> arch/powerpc/kernel/syscalls/syscalltbl.sh | 38 +++ >> > >> > I think you should only need a single .tbl input file here. >> >> Yes, we can do that way also.As I mentioned, it will add >> more complexity in the script. >> >> The script has to be smart enough to parse the >> .tbl if we add more thing in the .tble file. It need more >> logic in the scripts. This is not common. So if you keep >> separate .tbl we can avoid this. > > But all three existing architectures (x86, s390 and arm) already > have the capability to parse the table and generate different output > from that. Yeah, we want that on powerpc too. If the script needs to be more complex that's fine, if it can't be shared across arches that's fine, the main thing for me is that wiring up a syscall can be done by adding a single line in a single file. cheers