From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C0AEC43A1D for ; Thu, 12 Jul 2018 05:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E69A820C0C for ; Thu, 12 Jul 2018 05:24:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E69A820C0C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbeGLFcg (ORCPT ); Thu, 12 Jul 2018 01:32:36 -0400 Received: from ozlabs.org ([203.11.71.1]:57581 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbeGLFcg (ORCPT ); Thu, 12 Jul 2018 01:32:36 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 41R4BJ6tf8z9s01; Thu, 12 Jul 2018 15:24:40 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Oscar Salvador , Pavel Tatashin Cc: Andrew Morton , broonie@kernel.org, mhocko@suse.cz, Stephen Rothwell , linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux Memory Management List , LKML , mm-commits@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bhe@redhat.com, aneesh.kumar@linux.ibm.com, khandual@linux.vnet.ibm.com Subject: Re: Boot failures with "mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER" on powerpc (was Re: mmotm 2018-07-10-16-50 uploaded) In-Reply-To: References: <20180710235044.vjlRV%akpm@linux-foundation.org> <87lgai9bt5.fsf@concordia.ellerman.id.au> <20180711133737.GA29573@techadventures.net> Date: Thu, 12 Jul 2018 15:24:38 +1000 Message-ID: <87efg981rd.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oscar Salvador writes: > El dc., 11 jul. 2018 , 15:56, Pavel Tatashin va > escriure: > >> I am OK, if this patch is removed from Baoquan's series. But, I would >> still like to get rid of CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER, I >> can work on this in my sparse_init re-write series. ppc64 should >> really fallback safely to small chunks allocs, and if it does not >> there is some existing bug. Michael please send the config that you >> used. >> >> Thank you, >> Pavel >> On Wed, Jul 11, 2018 at 9:37 AM Oscar Salvador >> wrote: >> > >> > On Wed, Jul 11, 2018 at 10:49:58PM +1000, Michael Ellerman wrote: >> > > akpm@linux-foundation.org writes: >> > > > The mm-of-the-moment snapshot 2018-07-10-16-50 has been uploaded to >> > > > >> > > > http://www.ozlabs.org/~akpm/mmotm/ >> > > ... >> > > >> > > > * mm-sparse-add-a-static-variable-nr_present_sections.patch >> > > > * mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch >> > > > * mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch >> > > > * >> mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch >> > > > * mm-sparse-optimize-memmap-allocation-during-sparse_init.patch >> > > > * >> mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch >> > > >> > > > * mm-sparse-remove-config_sparsemem_alloc_mem_map_together.patch >> > > >> > > This seems to be breaking my powerpc pseries qemu boots. >> > > >> > > The boot log with some extra debug shows eg: >> > > >> > > $ make pseries_le_defconfig >> > >> > Could you please share the config? >> > I was not able to find such config in the kernel tree. >> >> > I just roughly check, but if I checked the right place, > vmemmap_populated() checks for the section to contain the flags we are > setting in sparse_init_one_section(). Yes. > But with this patch, we populate first everything, and then we call > sparse_init_one_section() in sparse_init(). > As I said I could be mistaken because I just checked the surface. Yeah I think that's correct. This might just be a bug in our code, let me look at it a bit. cheers