From: NeilBrown <neilb@suse.com>
To: "Javier González" <jg@lightnvm.io>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()
Date: Mon, 24 Apr 2017 12:32:04 +1000 [thread overview]
Message-ID: <87efwir0wr.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <F684F05A-679F-4704-A70E-7C1EE92B83E7@lightnvm.io>
[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]
On Sat, Apr 22 2017, Javier González wrote:
>> On 20 Apr 2017, at 07.38, NeilBrown <neilb@suse.com> wrote:
>>
>> blk_queue_split() is always called with the last arg being q->bio_split,
>> where 'q' is the first arg.
>>
>> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
>> q->bio_split.
>>
>> This is inconsistent and unnecessary. Remove the last arg and always use
>> q->bio_split inside blk_queue_split()
>>
>> Signed-off-by: NeilBrown <neilb@suse.com>
>> ---
>> block/blk-core.c | 2 +-
>> block/blk-merge.c | 9 ++++-----
>> block/blk-mq.c | 2 +-
>> drivers/block/drbd/drbd_req.c | 2 +-
>> drivers/block/pktcdvd.c | 2 +-
>> drivers/block/ps3vram.c | 2 +-
>> drivers/block/rsxx/dev.c | 2 +-
>> drivers/block/umem.c | 2 +-
>> drivers/block/zram/zram_drv.c | 2 +-
>> drivers/lightnvm/rrpc.c | 2 +-
>> drivers/md/md.c | 2 +-
>> drivers/s390/block/dcssblk.c | 2 +-
>> drivers/s390/block/xpram.c | 2 +-
>> include/linux/blkdev.h | 3 +--
>> 14 files changed, 17 insertions(+), 19 deletions(-)
>>
>
> It most probably made it to Jens' tree after you made these changes, but
> in drivers/lightnvm/pblk-init.c we also use blk_queue_split() in a
> couple of places inside pblk_rw_io().
Ahh, yes - thanks. That will need to same small change.
Jens, do you prefer a resend, or and update patch, or to just add this
change manually?
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-04-24 2:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 5:38 [PATCH 00/11] block: assorted cleanup for bio splitting and cloning NeilBrown
2017-04-20 5:38 ` [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() NeilBrown
2017-04-21 11:21 ` Christoph Hellwig
2017-04-21 15:14 ` Ming Lei
2017-04-22 9:16 ` Javier González
2017-04-24 2:32 ` NeilBrown [this message]
2017-04-20 5:38 ` [PATCH 02/11] blk: make the bioset rescue_workqueue optional NeilBrown
2017-04-21 11:24 ` Christoph Hellwig
2017-04-24 1:51 ` NeilBrown
2017-04-24 15:10 ` Christoph Hellwig
2017-05-01 5:00 ` NeilBrown
2017-05-01 14:02 ` Jens Axboe
2017-05-02 3:33 ` NeilBrown
2017-04-20 5:38 ` [PATCH 07/11] pktcdvd: use bio_clone_fast() instead of bio_clone() NeilBrown
2017-04-21 11:29 ` Christoph Hellwig
2017-04-20 5:38 ` [PATCH 05/11] rbd: " NeilBrown
2017-04-21 11:31 ` Christoph Hellwig
2017-04-20 5:38 ` [PATCH 03/11] blk: use non-rescuing bioset for q->bio_split NeilBrown
2017-04-21 11:25 ` Christoph Hellwig
2017-04-20 5:38 ` [PATCH 04/11] block: Improvements to bounce-buffer handling NeilBrown
2017-04-21 11:28 ` Christoph Hellwig
2017-04-21 15:39 ` Ming Lei
2017-04-20 5:38 ` [PATCH 06/11] drbd: use bio_clone_fast() instead of bio_clone() NeilBrown
2017-04-21 11:30 ` Christoph Hellwig
2017-04-20 5:38 ` [PATCH 09/11] bcache: use kmalloc to allocate bio in bch_data_verify() NeilBrown
2017-04-21 11:31 ` Christoph Hellwig
2017-04-21 11:32 ` Kent Overstreet
2017-04-21 15:41 ` Ming Lei
2017-04-20 5:38 ` [PATCH 08/11] xen-blkfront: remove bio splitting NeilBrown
2017-04-20 10:00 ` Roger Pau Monné
2017-04-21 11:36 ` Christoph Hellwig
2017-04-21 11:46 ` Roger Pau Monne
2017-04-20 5:38 ` [PATCH 11/11] block: don't check for BIO_MAX_PAGES in blk_bio_segment_split() NeilBrown
2017-04-21 11:34 ` Christoph Hellwig
2017-04-21 15:48 ` Ming Lei
2017-04-24 3:16 ` NeilBrown
2017-04-24 3:14 ` NeilBrown
2017-04-20 5:38 ` [PATCH 10/11] block: remove bio_clone() and all references NeilBrown
2017-04-21 11:32 ` Christoph Hellwig
2017-04-21 15:43 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efwir0wr.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=axboe@kernel.dk \
--cc=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).