From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751052AbdAMQg6 (ORCPT ); Fri, 13 Jan 2017 11:36:58 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46332 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbdAMQg4 (ORCPT ); Fri, 13 Jan 2017 11:36:56 -0500 From: Gregory CLEMENT To: Sebastian Hesselbarth Cc: Bhumika Goyal , julia.lawall@lip6.fr, rmk+kernel@arm.linux.org.uk, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: dove: constify reset_control_ops structures References: <1483979690-7619-1-git-send-email-bhumirks@gmail.com> Date: Fri, 13 Jan 2017 17:36:42 +0100 In-Reply-To: <1483979690-7619-1-git-send-email-bhumirks@gmail.com> (Bhumika Goyal's message of "Mon, 9 Jan 2017 22:04:50 +0530") Message-ID: <87eg069asl.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, On lun., janv. 09 2017, Bhumika Goyal wrote: > Declare reset_control_ops as const as they are only stored in the ops > field of a reset_controller_dev structure. This field is of type const > struct reset_control_ops *, so reset_control_ops structures having this > property can be declared as const. > Done using Coccinelle: > > @r1 disable optional_qualifier@ > identifier i; > position p; > @@ > static struct reset_control_ops i@p={...}; > > @ok1@ > identifier r1.i; > position p; > struct reset_controller_dev x; > @@ > x.ops=&i@p; > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct reset_control_ops i; > > File size before: drivers/soc/dove/pmu.o > text data bss dec hex filename > 2447 112 16 2575 a0f drivers/soc/dove/pmu.o > > File size after: drivers/soc/dove/pmu.o > text data bss dec hex filename > 2479 80 16 2575 a0f drivers/soc/dove/pmu.o > If you agree with this patch I will apply it on mvebu/soc. Thanks, Gregory > Signed-off-by: Bhumika Goyal > --- > drivers/soc/dove/pmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c > index 039374e..95d77ec 100644 > --- a/drivers/soc/dove/pmu.c > +++ b/drivers/soc/dove/pmu.c > @@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id) > return 0; > } > > -static struct reset_control_ops pmu_reset_ops = { > +static const struct reset_control_ops pmu_reset_ops = { > .reset = pmu_reset_reset, > .assert = pmu_reset_assert, > .deassert = pmu_reset_deassert, > -- > 1.9.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com