From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977AbcFJJRK (ORCPT ); Fri, 10 Jun 2016 05:17:10 -0400 Received: from mga11.intel.com ([192.55.52.93]:44205 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbcFJJRH (ORCPT ); Fri, 10 Jun 2016 05:17:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,449,1459839600"; d="asc'?scan'208";a="994910968" From: Felipe Balbi To: Roger Quadros , grygorii.strashko@ti.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Roger Quadros Subject: Re: [PATCH] usb: dwc3: fix runtime PM in error path In-Reply-To: <1465548878-30085-1-git-send-email-rogerq@ti.com> References: <1465548878-30085-1-git-send-email-rogerq@ti.com> User-Agent: Notmuch/0.22+11~g124a67e (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-pc-linux-gnu) Date: Fri, 10 Jun 2016 12:16:51 +0300 Message-ID: <87eg85769o.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: > If there is a failure after pm_runtime_enable/get_sync() > we need to call pm_runtime_disable/put_sync(). > > Otherwise it will lead to an unbalanced pm_runtime_enable() on the > subsequent probe if the earlier probe bailed out due to -EPROBE_DEFER. > > Signed-off-by: Roger Quadros where is this supposed to be applied? You're not checking if pm_runtime_get() failed at all. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXWoWDAAoJEIaOsuA1yqRE+IsQAJgOxZL5Zl+BYDAo07/hzqP0 27X07KxH+S74EZa/GEzNBFoA2+7p2LUuCx9FAUJUITQe9mWT8EIgcxFNl6qFOw1V Ra1eHBGLtv/BHJD+yPxvjg5KAozEyVN9RoNAQ0AUfzaExwRrqf0hBIq27tUIDpT/ EXvD+icQmPc+pOGe8wUgJE3DrkZ0txeSD1VsCLpLMV26kne6USWonhMyxwNJBgRD 7OKSeNvgJFiLEnsW5xvvtZ4dJzpxB9+TBoMcylTsW8GRsol8DeawI7VJulifGSIX Zo58t6P91jDn1B9nLwQpKeiyY8mcPuITjH67XeNw+F+2UHIHK4sVBtt9R5SGsrAL fPdW6O9LDOskISUqrifiTmKElkuJ+c16Ny95vHs350nGROghOJTcXULTk/rY83oN MYV8G8fw1pP9UU0QT2ZI6FHn7KQw/q7o9A0dQr/klRDHZj3U3DYguYFbAa5R3GWb vnTmrOoFcKEUELNyLwOUC1p9uhmpfppZtEbN75l9BjvwzoRC7fP7Qejx0heX4521 eOFFtgVY5nSMoGkW/jMUrRHQSY/yXzzGMEgJ0eCrPFMbzAAfy6ISh6+znMk8Bm2o 8dtzJnB7WXQR50GtAOJ+CLKc5g6S7sCO6NlmvHjWUpADwEbKF8PiYZdO8cio1NO5 /rVIQjPPvscEueM0Dhyq =u8Xm -----END PGP SIGNATURE----- --=-=-=--