archive mirror
 help / color / mirror / Atom feed
From: Andreas Schwab <>
To: Masahiro Yamada <>
Cc: Nathan Chancellor <>,,,, Ard Biesheuvel <>,
	Thorsten Leemhuis <>,
	Catalin Marinas <>,
	Will Deacon <>,,, Dennis Gilmore <>,
	Albert Ou <>, Arnd Bergmann <>,
	Jisheng Zhang <>,
	Nicolas Schier <>,
	Palmer Dabbelt <>,
	Paul Walmsley <>,
Subject: Re: [PATCH v2] arch: fix broken BuildID for arm64 and riscv
Date: Thu, 05 Jan 2023 10:21:03 +0100	[thread overview]
Message-ID: <87fscp2v7k.fsf@igel.home> (raw)
In-Reply-To: <> (Masahiro Yamada's message of "Thu, 5 Jan 2023 12:22:50 +0900")

On Jan 05 2023, Masahiro Yamada wrote:

> I do not understand why 99cb0d917ffa affected this.
> I submitted a fix to shoot the error message "discarded section .exit.text"
> I do not understand the binutils commit either,
> but it might have made something good
> because EXIT_TEXT appears twice, in .exit.text, and /DISCARD/.

I think the issue is that the introdution of a second /DISCARD/
directive early in script changes the order of evaluation of the other
/DISCARD/ directive when binutils < 2.36 is used, so that the missing
RUNTIME_DISCARD_EXIT started to become relevant.  As long as /DISCARD/
only appears last, the effect of EXIT_TEXT inside it is always
overridden by its occurence in the .exit.exit output section directive.
When another /DISCARD/ occurs early (and binutils < 2.36 is used) the
effect of EXIT_TEXT inside the second /DISCARD/ (when merged with the
first) overrides its occurence in the .exit.text directive.  The
binutils commit changed that because the new /DISCARD/ directive no
longer affects the order of evaluation of the rest of the directives.

Andreas Schwab,
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  reply	other threads:[~2023-01-05  9:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-26 18:45 [PATCH v2] arch: fix broken BuildID for arm64 and riscv Masahiro Yamada
2022-12-29 16:22 ` Palmer Dabbelt
2023-01-02  4:16 ` Nathan Chancellor
2023-01-02  7:08   ` Linux kernel regression tracking (#info)
2023-01-05  3:22   ` Masahiro Yamada
2023-01-05  9:21     ` Andreas Schwab [this message]
2023-01-05  9:27       ` Ard Biesheuvel
2023-01-05 11:14         ` Michael Ellerman
2023-01-05 13:49         ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fscp2v7k.fsf@igel.home \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).